-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make mean(::Chi) more robust #1305
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1305 +/- ##
=======================================
Coverage 81.55% 81.55%
=======================================
Files 115 115
Lines 6641 6642 +1
=======================================
+ Hits 5416 5417 +1
Misses 1225 1225
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this seems reasonable 👍 Can you add the MWE as a test?
I tried to generate the continuous_test.ref.json file on my local environment, but it failed with the following error:
I'm using R 4.0.3. Perhaps newer than expected? Sorry, I'm not so familiar with the R language. |
Oh, I didn't realize that it's mainly/only tested with the R/json setup. I thought you could just add a check that the example above does not return |
Great. That's much easier. I've added a test in a new file chi.jl. |
Thank you @bicycle1885! |
Current:
PR: