Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1358 #1359

Merged
merged 2 commits into from
Jul 5, 2021
Merged

Fix #1358 #1359

merged 2 commits into from
Jul 5, 2021

Conversation

devmotion
Copy link
Member

Fixes #1358.

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2021 •
edited
Loading

Codecov Report

Merging #1359 (be7e632) into master (34df63d) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1359      +/-   ##
==========================================
- Coverage   82.76%   82.76%   -0.01%     
==========================================
  Files         116      116              
  Lines        6672     6671       -1     
==========================================
- Hits         5522     5521       -1     
  Misses       1150     1150
Impacted Files Coverage Δ
src/univariates.jl 74.46% <ø> (ø)
src/functionals.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34df63d...be7e632. Read the comment docs.

@devmotion devmotion mentioned this pull request Jul 4, 2021
Merged
@t-bltg t-bltg mentioned this pull request Jul 5, 2021
Merged
3 tasks
mschauer
mschauer reviewed Jul 5, 2021
View reviewed changes
src/univariates.jl
@@ -646,7 +646,7 @@ macro _delegate_statsfuns(D, fpre, psyms...)
pargs = [Expr(:(.), :d, Expr(:quote, s)) for s in psyms]

# output type of `quantile` etc.
T = :($D isa DiscreteUnivariateDistribution ? Int : Real)
T = :($D <: DiscreteUnivariateDistribution ? Int : Real)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this overwritten somewhere for discrete distributions which are not supported on the integers?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but the macro that forwards calculations to StatsFuns is only used for discrete distributions with integer valued support.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR only fixes the issue that was introduced in 0.25.7 when the eval parts of the macro where removed but does not introduce any new behaviour.

@mschauer mschauer merged commit 43cd959 into master Jul 5, 2021
@devmotion devmotion deleted the dw/fix_poisson branch July 5, 2021 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mschauer mschauer mschauer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI build failure with latest versions
3 participants
@devmotion @codecov-commenter @mschauer