Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support StatsBase 0.34 #1714

Merged
merged 1 commit into from
May 1, 2023
Merged

Support StatsBase 0.34 #1714

merged 1 commit into from
May 1, 2023

Conversation

ararslan
Copy link
Member

@ararslan ararslan commented May 1, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 1, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (630e1c9) 85.82% compared to head (3d30113) 85.82%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1714   +/-   ##
=======================================
  Coverage   85.82%   85.82%           
=======================================
  Files         137      137           
  Lines        8315     8315           
=======================================
  Hits         7136     7136           
  Misses       1179     1179           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ararslan ararslan closed this May 1, 2023
@ararslan ararslan reopened this May 1, 2023
@ararslan
Copy link
Member Author

ararslan commented May 1, 2023

The DistributionsAD.jl/Tracker integration test failed with both StatsBase 0.33 and 0.34 (visible in the GitHub Actions logs) and so is unrelated to this PR

@ararslan ararslan merged commit b11806b into master May 1, 2023
@ararslan ararslan deleted the aa/statsbase-0.34 branch May 1, 2023 23:14
@devmotion
Copy link
Member

Yes, I saw it and pushed a fix and release of DistributionsAD. Should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants