Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inference failures #1722

Merged
merged 3 commits into from
May 17, 2023
Merged

Fix inference failures #1722

merged 3 commits into from
May 17, 2023

Conversation

devmotion
Copy link
Member

No description provided.

@devmotion devmotion requested a review from ararslan May 17, 2023 00:58
Copy link
Member

@ararslan ararslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming CI agrees, thanks for fixing!

@codecov-commenter
Copy link

codecov-commenter commented May 17, 2023

Codecov Report

Patch coverage: 86.15% and project coverage change: -0.03 ⚠️

Comparison is base (9cf6a74) 85.92% compared to head (7b32924) 85.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1722      +/-   ##
==========================================
- Coverage   85.92%   85.89%   -0.03%     
==========================================
  Files         139      139              
  Lines        8376     8389      +13     
==========================================
+ Hits         7197     7206       +9     
- Misses       1179     1183       +4     
Impacted Files Coverage Δ
src/truncate.jl 88.28% <83.33%> (-2.72%) ⬇️
src/truncated/normal.jl 85.82% <91.30%> (+0.21%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@devmotion devmotion merged commit ef42afb into master May 17, 2023
@devmotion devmotion deleted the dw/truncated_normal branch May 17, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants