Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Wrong quantiles calculated for some Truncated #1726 #1727

Merged
merged 3 commits into from
Jun 19, 2023
Merged

Fix Wrong quantiles calculated for some Truncated #1726 #1727

merged 3 commits into from
Jun 19, 2023

Conversation

waldie11
Copy link
Contributor

As described in
#1726, there occur small numbers-big number problems while evaluating quantiles on Truncated.

This Fix uses the knowledge on the upper bound of Truncated to properly limit the output.

@waldie11
Fix Wrong quantiles calculated for some Truncated #1726
0f5fa3f 
As described in
[#1726](#1726), there occur small numbers-big number problems while evaluating quantiles on `Truncated`.

This Fix uses the knowledge on the upper bound of `Truncated` to properly limit the output.
@waldie11 waldie11 mentioned this pull request May 23, 2023
Closed
devmotion
devmotion reviewed May 24, 2023
View reviewed changes
Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! I made a suggestion for how to improve it a bit 🙂

Can you also add tests of the fixed issue?

src/truncate.jl Outdated Show resolved Hide resolved
@waldie11
Copy link
Contributor Author

waldie11 commented Jun 6, 2023

@devmotion you are welcome 😉

I think the examples resemble the discussed issues covered by this patch.

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.20 🎉

Comparison is base (87f323a) 85.71% compared to head (1e268bf) 85.91%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1727      +/-   ##
==========================================
+ Coverage   85.71%   85.91%   +0.20%     
==========================================
  Files         140      142       +2     
  Lines        8455     8569     +114     
==========================================
+ Hits         7247     7362     +115     
+ Misses       1208     1207       -1
Impacted Files Coverage Δ
src/truncate.jl 88.59% <100.00%> (+0.30%) ⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@waldie11 waldie11 requested a review from devmotion June 12, 2023 08:45
@waldie11
Copy link
Contributor Author

@devmotion bump

devmotion
devmotion approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I was busy the last weeks with other things. The PR looks good to me, thanks!

@devmotion devmotion merged commit c480dc0 into JuliaStats:master Jun 19, 2023
@quildtide quildtide mentioned this pull request Aug 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devmotion devmotion devmotion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waldie11 @codecov-commenter @devmotion