Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project.toml cleanup #1752

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Project.toml cleanup #1752

merged 2 commits into from
Aug 3, 2023

Conversation

dkarrasch
Copy link
Member

SparseArrays.jl is just a test dependency, and Pkg prefers a different order. Aqua.jl keeps complaining about a few ambiguities and two unbound type parameters in product.jl, but for some strange reason I couldn't resolve the unbound type parameters.

Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (given tests pass).

@dkarrasch
Copy link
Member Author

Good to go? Or shall we rerun the tests?

@devmotion
Copy link
Member

Test failures are only on nightly (and probably unrelated), so IMO good to go 🙂

@devmotion devmotion merged commit 72ef1ad into master Aug 3, 2023
7 of 8 checks passed
@devmotion devmotion deleted the dk/pkg_cleanup branch August 3, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants