Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add partype method to lognormal and semicircle #1773

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

add partype method to lognormal and semicircle #1773

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c82cf7c
add partype method to lognormal and semicircle
bgctw Sep 8, 2023
4a19bc7
Update src/univariate/continuous/lognormal.jl
bgctw Sep 8, 2023
7272546
Update src/univariate/continuous/semicircle.jl
bgctw Sep 8, 2023
6ae492c
add tests on par_type and Float32
bgctw Sep 8, 2023
ae09da6
adapt partype testing to special case
bgctw Sep 21, 2023
b8511e9
breaking adapt tests of special cases: Int partype
bgctw Sep 21, 2023
f523760
LocationScale: do not promote T
bgctw Sep 22, 2023
9219995
Update .gitignore
bgctw Sep 25, 2023
7392e9b
revert DiscreteUniform to non-parametric
bgctw Sep 25, 2023
3021725
generalize check of partype for non-Real parameters
bgctw Sep 25, 2023
b614da3
Update src/univariate/locationscale.jl
bgctw Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/univariate/continuous/lognormal.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ stdlogx(d::LogNormal) = d.σ
mean(d::LogNormal) = ((μ, σ) = params(d); exp(μ + σ^2/2))
median(d::LogNormal) = exp(d.μ)
mode(d::LogNormal) = ((μ, σ) = params(d); exp(μ - σ^2))
partype(d::LogNormal{T}) where {T<:Real} = T
bgctw marked this conversation as resolved.
Show resolved Hide resolved

function var(d::LogNormal)
(μ, σ) = params(d)
Expand Down
2 changes: 2 additions & 0 deletions src/univariate/continuous/semicircle.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ Semicircle(r::Integer; check_args::Bool=true) = Semicircle(float(r); check_args=
@distr_support Semicircle -d.r +d.r

params(d::Semicircle) = (d.r,)
partype(d::Semicircle{T}) where {T<:Real} = T
bgctw marked this conversation as resolved.
Show resolved Hide resolved


mean(d::Semicircle) = zero(d.r)
var(d::Semicircle) = d.r^2 / 4
Expand Down
Loading