Fréchet distribution #238
Merged
Fréchet distribution #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks really good. I want to give it one more pass before merging. One minor question: do you have a source for your parameter names? They seem to switch over the course of the math/code and aren't the names used by Wikipedia. |
|
I've used the code for Weibull distribution making only necessary changes, so all the variable choices are from there. I guess if variables need to be cleaned up, Weibull should be fixed as well. Personally, I like |
|
@alyst There was some refactoring going on in the package. Would you please merge the latest master to your branch? |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements Fréchet distribution. It is based on the Weibull code.