Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating constants.jl - @irrational instead of @math_const #389

Merged
merged 1 commit into from
Jul 1, 2015

Conversation

ranjanan
Copy link
Contributor

No description provided.

@johnmyleswhite
Copy link
Member

Thanks for doing this. Let's see what Travis says (and hope Travis isn't wrong).

@ranjanan
Copy link
Contributor Author

It has failed the v0.3.10 test I think, but passed the nightly test. This was expected right? @spencerlyon2

@sglyon
Copy link
Member

sglyon commented Jun 30, 2015

Yes, I think this should be expected because @irrational is only defined on 0.4dev.

Getting something into Compat would (probably) be the best way to resolve the problem. That entails defining the @irrational as an unexported member of Base (from within Compat), making a release of Compat, then leveraging the new compat from within distributions.

@simonster
Copy link
Member

I took a different route in JuliaLang/Compat.jl#109 and defined Compat.@irrational instead of mucking with Base. If you change this code to import Compat.@irrational it should work once that's merged and Compat is bumped.

@ranjanan
Copy link
Contributor Author

Cool stuff @simonster . Let's hope Travis passes both tests.

@IainNZ
Copy link
Contributor

IainNZ commented Jul 7, 2015

@simonster can a new version be tagged?

@simonster
Copy link
Member

Tagged.

@ranjanan ranjanan deleted the patch-1 branch December 29, 2022 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants