Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is how I would approach #945, just as a start. It basically shows how to get the support business working without making the
eltype
a type parameter of thesupport
. It helps to definesupport(d, epsilon)
to find the numerical relevant support of unbounded distributions.I illustrate how the type signature of
DiscreteNonParametric
can be extended to allow uni- and multivariate nonparametric distributions.The crux is, that
Discrete
does not need to imply that the support is onlyInt
. All discrete distributions in the original meaning of the word (outcomes can be enumerated, e.g https://en.wikipedia.org/wiki/Probability_mass_function) can also by ofValueSupport
typeDiscrete
. I introduced some errors, so this is really just a sketch.