Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compat fixes for Julia 1.7 #547

Merged
merged 3 commits into from
Jul 28, 2021
Merged

compat fixes for Julia 1.7 #547

merged 3 commits into from
Jul 28, 2021

Conversation

palday
Copy link
Member

@palday palday commented Jul 28, 2021

Closes #532

  • deleted a dead path now that we've dropped pre 1.6 support
  • added an internal wrapper method to dodge some deprecation warnings in 1.7+

@codecov
Copy link

codecov bot commented Jul 28, 2021

Codecov Report

Merging #547 (0afce6c) into main (26a87d5) will increase coverage by 1.71%.
The diff coverage is 97.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #547      +/-   ##
==========================================
+ Coverage   94.44%   96.16%   +1.71%     
==========================================
  Files          27       27              
  Lines        2468     2425      -43     
==========================================
+ Hits         2331     2332       +1     
+ Misses        137       93      -44     
Impacted Files Coverage Δ
src/linearmixedmodel.jl 98.41% <ø> (+3.02%) ⬆️
src/linalg.jl 98.03% <96.77%> (+35.21%) ⬆️
src/likelihoodratiotest.jl 98.52% <100.00%> (ø)
src/linalg/pivot.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1edd541...0afce6c. Read the comment docs.

Copy link
Collaborator

@dmbates dmbates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this. Creating the pivoted_qr function was a good solution to avoid special-casing the code at every call to the decomposition.

I took the liberty of dropping the _zerocorr code while doing the code cleanup. You are welcome to change that if you don't think it belongs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjustments for julia-v1.7.0
2 participants