Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chol depwarn #34

Merged
merged 1 commit into from
Jan 19, 2016
Merged

Fix chol depwarn #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/chol.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
# needs special attention to Cholesky, as the syntax & behavior changes in 0.4-pre

if VERSION >= v"0.4.0-dev+4370"
if VERSION >= v"0.5.0-dev+907"
typealias CholType Cholesky{Float64, Matrix{Float64}}
chol_lower(a::Matrix{Float64}) = ctranspose(chol(a))

typealias CholTypeSparse SparseArrays.CHOLMOD.Factor{Float64}

chol_lower(cf::CholTypeSparse) = cf[:L]
elseif VERSION >= v"0.4.0-dev+4370"
# error("Choleksy changes in 0.4.0-dev+4370 (PR #10862), we are still working to make it work with these changes.")

typealias CholType Cholesky{Float64, Matrix{Float64}}
Expand Down