Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve handling of NaN in ranks and rank correlations #659

Merged
merged 7 commits into from
Mar 7, 2021
Merged

Improve handling of NaN in ranks and rank correlations #659

merged 7 commits into from
Mar 7, 2021

Commits on Feb 14, 2021

  1. Improve handling of NaN in ranks and rank correlations 

    Throw an error when NaN is encountered by rank functions, and make
`corspearman` return `NaN`, instead of silently sorting them at the end.
This is consistent with what `corkendall` and `cor` do.
    @nalimilan
    nalimilan committed Feb 14, 2021
    Configuration menu
    Copy the full SHA
    c596aa7 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2021

  1. More tests, change corkendall dimensions

    @nalimilan
    nalimilan committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    f8116c0 View commit details
    Browse the repository at this point in the history

  2. Another missing test

    @nalimilan
    nalimilan committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    480ef05 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2021

  1. Revert changes to ranking functions

    @nalimilan
    nalimilan committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    e09cbd2 View commit details
    Browse the repository at this point in the history

  2. Revert corkendall changes

    @nalimilan
    nalimilan committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    e7f16e3 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2021

  1. Cache any(isnan, Xi)

    @nalimilan
    nalimilan committed Feb 28, 2021
    Configuration menu
    Copy the full SHA
    84cfb9c View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2021

  1. Simplify anynan

    @nalimilan
    nalimilan committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    2437e07 View commit details
    Browse the repository at this point in the history