Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the test error on Julia nightly that I observed in #894. It's quite interesting: the tests fail because the error type of the modified
@test_throws
tests is different on nightly - but that's unrelated to StatsBase internals and caused by the construction of the matrix-valued arguments to the tested function calls. On Julia 1.9, we havewhereas on e.g. Julia 1.10 (beta2) we have
I assume it's simply a typo in our tests and it was always the intention to rather test the errors thrown by StatsBase instead of Base. It seems the tests were added in #659 originally.