Document support for special terms at run-time, one-sided formula #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #155 +/- ##
=======================================
Coverage 83.66% 83.66%
=======================================
Files 9 9
Lines 496 496
=======================================
Hits 415 415
Misses 81 81
Continue to review full report at Codecov.
|
oxinabox
reviewed
Sep 28, 2019
oxinabox
reviewed
Sep 28, 2019
oxinabox
reviewed
Sep 28, 2019
oxinabox
approved these changes
Sep 29, 2019
nalimilan
reviewed
Sep 30, 2019
docs/src/internals.md
Outdated
| ``` | ||
|
|
||
| This is workable if a little verbose, so the third (optional) step is to provide | ||
| additional "runtime" methods for the function that's used in the `@formula` |
There was a problem hiding this comment.
Suggested change
| additional "runtime" methods for the function that's used in the `@formula` | |
| additional "runtime" methods for the function that are used in the `@formula` |
There was a problem hiding this comment.
"function" is the head of this relative clause so single number is appropriate no? That is, it's the function that's used, not the methods...although now I see that this is potentially structurally ambiguous :)
kleinschmidt
force-pushed
the
dfk/docs-runtime-oneside
branch
from
c39a5db to
32c43e7
Compare
This was referenced Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some notes in the documentation for package developers about supporting run-time use of special terms, expanding on a short comment from slack with @Nosferican. It also updates the
poly/PolyTermexample to follow the revised guidelines.