-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix predict with confidence interval #160
Conversation
DataFrames aren't a dependency anymore.
Weird how this snuck in; I guess the predict PRs were opened while #71 was still being finalized and didn't touch any of the same code so I didn't notice. We really ought to have tests for this though, could you add some? |
Yes that seems to be what happened with #81.
JuliaStats/GLM.jl#335 adds tests in GLM. I'll have a look at adding tests here. |
Codecov Report
@@ Coverage Diff @@
## master #160 +/- ##
=========================================
+ Coverage 83.66% 84.87% +1.2%
=========================================
Files 9 9
Lines 496 496
=========================================
+ Hits 415 421 +6
+ Misses 81 75 -6
Continue to review full report at Codecov.
|
OK, tests added! |
Oh and bump the patch version? |
Done. |
DataFrames aren't a dependency anymore.
Fixes #159. Covered by tests at JuliaStats/GLM.jl#335 (we should add tests with a dummy model type at some point).