Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix predict with confidence interval #160

Merged
merged 3 commits into from
Oct 10, 2019
Merged

Fix predict with confidence interval #160

merged 3 commits into from
Oct 10, 2019

Conversation

nalimilan
Copy link
Member

@nalimilan nalimilan commented Oct 4, 2019

DataFrames aren't a dependency anymore.

Fixes #159. Covered by tests at JuliaStats/GLM.jl#335 (we should add tests with a dummy model type at some point).

DataFrames aren't a dependency anymore.
@kleinschmidt
Copy link
Member

Weird how this snuck in; I guess the predict PRs were opened while #71 was still being finalized and didn't touch any of the same code so I didn't notice. We really ought to have tests for this though, could you add some?

@nalimilan
Copy link
Member Author

Weird how this snuck in; I guess the predict PRs were opened while #71 was still being finalized and didn't touch any of the same code so I didn't notice.

Yes that seems to be what happened with #81.

We really ought to have tests for this though, could you add some?

JuliaStats/GLM.jl#335 adds tests in GLM. I'll have a look at adding tests here.

@codecov-io
Copy link

codecov-io commented Oct 7, 2019

Codecov Report

Merging #160 into master will increase coverage by 1.2%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #160     +/-   ##
=========================================
+ Coverage   83.66%   84.87%   +1.2%     
=========================================
  Files           9        9             
  Lines         496      496             
=========================================
+ Hits          415      421      +6     
+ Misses         81       75      -6
Impacted Files Coverage Δ
src/statsmodel.jl 86.44% <66.66%> (+10.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04a0ccf...1c9e9d6. Read the comment docs.

@nalimilan
Copy link
Member Author

OK, tests added!

@kleinschmidt
Copy link
Member

Oh and bump the patch version?

@nalimilan
Copy link
Member Author

Done.

@kleinschmidt kleinschmidt merged commit 6d581b1 into master Oct 10, 2019
@kleinschmidt kleinschmidt deleted the nl/predict branch October 10, 2019 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataFrame not defined error when including interval keyword argument
3 participants