Generalize ::Irrational to ::AbstractIrrational
#829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YingboMa
approved these changes
Jan 26, 2023
|
@shashi look into the test failures? |
|
IrrationalConstants 0.2 with the breaking change is released now, so I assume it would be good to update Symbolics. I updated the PR with the latest changes from the master branch, maybe that fixed the seemingly unrelated test failures? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking at usage of Irrational in packages (https://juliahub.com/ui/Search?q=Irrational&type=symbols&u=use&t=type), to estimate how breaking JuliaMath/IrrationalConstants.jl#19 (motivated by JuliaLang/julia#46531) will be. Symbolics showed up in the list of packages that define methods for Irrational but it seems the definition here could be generalized to support AbstractIrrational.