Added support for kwargs in @mock calls.
#21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
=========================================
+ Coverage 93.07% 93.6% +0.52%
=========================================
Files 4 2 -2
Lines 260 172 -88
=========================================
- Hits 242 161 -81
+ Misses 18 11 -7
Continue to review full report at Codecov.
|
|
Addressed in JuliaLang/julia#22646 and JuliaLang/Compat.jl#424 (v0.40) |
|
Rebased the PR |
omus
changed the title
@mock calls.@mock calls.
|
AppVeyor failure is just being unable to download the 32-bit nightly binaries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles
@mockcalls with keyword arguments (both:parametersand regular:kw). Currently, left theQuoteNodeon kwarg values out as it won't be necessary with #20.Fixes: #19