Ensure CUSTOM_REGIONS get compiled #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjram0s
approved these changes
Nov 17, 2020
Codecov Report
@@ Coverage Diff @@
## master #307 +/- ##
==========================================
- Coverage 93.73% 93.41% -0.33%
==========================================
Files 32 32
Lines 1532 1518 -14
==========================================
- Hits 1436 1418 -18
- Misses 96 100 +4
Continue to review full report at Codecov.
|
|
Some CI jobs failing with https://travis-ci.com/github/JuliaTime/TimeZones.jl/jobs/441885262#L291 |
mjram0s
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #305
Issue was introduced by 07e3c9e
regionswas being redefined without theutccustom region, which cause the later code compiling the time zones to ignoreutcas well.I did a
union!rather than concatenating to avoid compiling anything twice.