Build at package initialization time (if required) #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've decided to keep this change out of the TimeZones.jl 1.9.0 release. This change has a decent potential for breakage and I'd like to separate this change from the switch over to using scratch spaces and the tzjfile format. |
|
I lost track of this PR. Was superseded by #441 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #389 (comment) for details. PR causes
TimeZones.buildto automatically be called if the desired tzdata version has not previously been built. This should:TimeZones.build()themselvesdeps/build.jlwas not triggeredThe main concerns with this change is that it may not play nicely with PackageCompiler.jl and users may not like that artifact retrieval and some processing could occur at package initialization time.