Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use precompiled time zone information from TZJData.jl #441

Merged
merged 29 commits into from
Aug 22, 2023
Merged
Show file tree
Hide file tree
Changes from 28 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
a45cb89
Reintroduce downloading build
omus Jul 25, 2023
d5d7e0a
Drop _tz_source_dir/_compiled_dir functions
omus Jul 25, 2023
5c5379a
Initial ext tzdata support
omus Jul 25, 2023
1f930f6
Automatically build Windows translation file
omus Jul 25, 2023
ef737bb
Restore src/tzdata/archive.jl
omus Jul 29, 2023
c5f46bc
Update tests
omus Jul 29, 2023
641d05b
Functional
omus Jul 29, 2023
150325b
Use TZJData for compiled time zones
omus Jul 29, 2023
8c6bfd8
Use Artifacts instead of LazyArtifacts
omus Jul 29, 2023
cb916b1
Artifact tests for unicode-cldr
omus Jul 29, 2023
b6e8388
Remove tzdata artifacts
omus Jul 29, 2023
621822e
Fix archive.jl
omus Jul 29, 2023
f4a9e08
Update dev/Manifest.toml
omus Aug 7, 2023
de80ebb
Remove deps/build.jl
omus Aug 7, 2023
e069996
Corrections to CI tests
omus Aug 7, 2023
ebe603e
Update docs/Manifest.toml
omus Aug 7, 2023
325dcd8
fixup! Corrections to CI tests
omus Aug 7, 2023
0dea22d
Fix kwargs in TZData.compile
omus Aug 7, 2023
8a8ad50
Refactor build function
omus Aug 9, 2023
efc611e
fixup! Refactor build function
omus Aug 10, 2023
213418e
Use p7zip_jll for unpacking
omus Aug 10, 2023
48dd160
Drop DEFAULT_TZDATA_VERSION
omus Aug 12, 2023
bcee05d
Drop TZData.ARTIFACT_TOML
omus Aug 12, 2023
32a07e8
Update docs/Manifest.toml
omus Aug 12, 2023
a205237
Add LazyArtifacts to benchmark/Project.toml
omus Aug 12, 2023
0b4d44d
Create `_reload_cache!`
omus Aug 12, 2023
aba714a
Keep unused dependency on LazyArtifacts
omus Aug 12, 2023
e08c65a
Remove empty _COMPILED_DIR check
omus Aug 12, 2023
ff5b8ab
Add compat for TZJData and p7zip_jll
omus Aug 22, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 6 additions & 18 deletions .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,12 @@ on:
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.ref != 'refs/heads/master' || github.run_number }}
cancel-in-progress: ${{ github.ref != 'refs/heads/master' }}

# Only download the tzdata version used in TimeZones.jl's tests to avoid unnecessary
# load on IANA's servers.
env:
JULIA_TZ_VERSION: 2016j # Matches tzdata version used in tests

jobs:
test:
name: Julia ${{ matrix.version }} - ${{ matrix.os }} - ${{ matrix.arch }}
Expand Down Expand Up @@ -45,22 +51,6 @@ jobs:
version: ${{ matrix.version }}
arch: ${{ matrix.arch }}
- uses: julia-actions/cache@v1
# Only download the tzdata version used in TimeZones.jl's tests to avoid unnecessary
# load on IANA's servers. However, if the DEFAULT_TZDATA_VERSION constant was
# changed we need to also build the version specified by the constant to ensure it can be
# compiled.
# Note: The `git diff` command has a `--quiet` flag that will suppress output but doesn't
# catch all changes.
#
# https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-commands-for-github-actions#setting-an-environment-variable
- run: |
git fetch origin +:refs/remotes/origin/HEAD
if git diff --exit-code -G"^const DEFAULT_TZDATA_VERSION" origin/HEAD..HEAD > /dev/null; then
echo "JULIA_TZ_VERSION=$TZDATA_VERSION" >> $GITHUB_ENV
fi
shell: bash
env:
TZDATA_VERSION: 2016j # Matches tzdata version used in tests
- uses: julia-actions/julia-buildpkg@latest
- uses: julia-actions/julia-runtest@latest
- uses: julia-actions/julia-processcoverage@v1
Expand All @@ -83,8 +73,6 @@ jobs:
git fetch origin +:refs/remotes/origin/HEAD
julia --project=benchmark/ -e 'using Pkg; Pkg.instantiate(); Pkg.develop(PackageSpec(path=pwd()))'
julia --project=benchmark/ -e 'using PkgBenchmark, TimeZones; export_markdown(stdout, judge(TimeZones, "origin/HEAD", verbose=false))'
env:
TZDATA_VERSION: 2016j # Matches tzdata version used in tests

doctest:
name: Documentation - DocTests
Expand Down
Loading
Loading