Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore RecipesBase dep to fix 1.6 #461

Merged
merged 1 commit into from
May 22, 2024

Conversation

ericphanson
Copy link
Contributor

Copy link

@odow odow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can probably be removed from extras and targets?

@ericphanson
Copy link
Contributor Author

I'm not 100% sure, but it seems to have been there pre-#459 so I think it would make sense to leave it to keep this as a minimal revert of the broken bit

@omus
Copy link
Member

omus commented May 22, 2024

My bad. It's way too easy to miss this. Why can't I have the CI fail for TimeZones itself?

@codecov-commenter
Copy link

codecov-commenter commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.07%. Comparing base (2bc8f50) to head (c46befb).
Report is 5 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #461      +/-   ##
==========================================
- Coverage   92.79%   92.07%   -0.72%     
==========================================
  Files          39       39              
  Lines        1818     1830      +12     
==========================================
- Hits         1687     1685       -2     
- Misses        131      145      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@omus
Copy link
Member

omus commented May 22, 2024

I've made another PR to add a CI check to ensure this doesn't happen again: #462

@omus omus changed the title restore RecipesBase dep to fix 1.6 Restore RecipesBase dep to fix 1.6 May 22, 2024
@omus omus merged commit e9919ef into JuliaTime:master May 22, 2024
15 checks passed
@ericphanson ericphanson deleted the eph/fix-recipesbase branch May 22, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants