Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constraint on the VTK version #43

Closed
henry2004y opened this issue Oct 7, 2023 · 5 comments · Fixed by #59
Closed

Constraint on the VTK version #43

henry2004y opened this issue Oct 7, 2023 · 5 comments · Fixed by #59

Comments

@henry2004y
Copy link
Contributor

Hi,

While testing to read one ImageData generated by ParaView 5.11, I noticed that the VTK file version was asserted to be v"1.0". The file version generated by ParaView 5.11 is 2.2, and the latest VTK version is 3.0.

I am wondering if there is a reason for only supporting version 1.0? If I remove

@assert version == v"1.0"

it seems that the reader still works in my limited attempts.

Thanks!
@sloede
Copy link
Member

sloede commented Oct 7, 2023

I checked and indeed, there is no official VTK XML spec file findable on the internet. We thus do not know what version 1 or higher (or lower) really means. Thus, feel free to create a PR that removes this check and we will be happy to merge it.

@henry2004y
Copy link
Contributor Author

I know nothing about the specific differences, but let's hope it doesn't break anything.

The VTKFileFormats briefly mentioned that v1.0 and v2.0 is compatible with v3.0, and some older names are discouraged (e.g. aspect ratio in v1.0 v.s. spacing in v2.0 for structured points). I do not see any real difference.

@henry2004y henry2004y mentioned this issue Oct 7, 2023
Merged
@sloede
Copy link
Member

sloede commented Oct 8, 2023

The VTKFileFormats briefly mentioned that v1.0 and v2.0 is compatible with v3.0, and some older names are discouraged (e.g. aspect ratio in v1.0 v.s. spacing in v2.0 for structured points). I do not see any real difference.

Yes, but they refer to the legacy formats, while we only support the XML file formats, for which no version information has ever been released publicly (see also https://gitlab.kitware.com/vtk/vtk/-/issues/17675).

@MarDiehl
Copy link
Contributor

I use a rather recent version of VTK (9.3.0 from https://archlinux.org/packages/extra/x86_64/vtk) and the written image data has version 0.1. Would it be possible to further relax the version and essentially accept everything until the different versions are documented?

@sloede
Copy link
Member

sloede commented Jun 11, 2024

Yes, that's fine with me. If you create a PR that removes the checks, I'll merge it 😊

@sloede sloede mentioned this issue Jun 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

do not constrain version MarDiehl/ReadVTK.jl
3 participants
@sloede @MarDiehl @henry2004y