Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not constrain version #59

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Conversation

MarDiehl
Copy link
Contributor

@MarDiehl MarDiehl commented Jun 11, 2024

Consistent information about VTK XML file formats, in particular on versions, is not available.
Since recent versions of the VTK library still write out files labelled as version 0.1, not enforcing a particular version seems to be the best option at the moment.

Resolves #43

Consistent information about VTK XML file formats, in particular on
versions, is not available.
Since recent versions of the VTK library still write out files labelled
as version 0.1, not enforcing a particular version seems to be the best
option at the moment.
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@MarDiehl
Copy link
Contributor Author

I tried to understand what's going wrong. All errors are related to missing files in ReadVTK.jl\test\pvtk_files.jl

  • SystemError: opening file "fields\fields_1.vtr": No such file or directory
  • SystemError: opening file "fields\fields_1.vti": No such file or directory
  • SystemError: opening file "simulation\simulation_1.vtu": No such file or directory
  • SystemError: opening file "fields\fields_1.vts": No such file or directory

I can reproduce it locally, but don't really understand what's going on.

@ranocha ranocha requested a review from sloede June 12, 2024 09:54
@ranocha
Copy link
Member

ranocha commented Aug 19, 2024

I fixed the CI issues in #61. Thanks for your contribution!

@ranocha ranocha enabled auto-merge (squash) August 19, 2024 09:40
@ranocha ranocha disabled auto-merge August 19, 2024 09:52
@ranocha ranocha merged commit 56e07b2 into JuliaVTK:main Aug 19, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Constraint on the VTK version
3 participants