Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

possible test failure in upcoming Julia version 1.5 #62

Closed
rfourquet opened this issue Apr 24, 2020 · 1 comment · Fixed by #63
Closed

possible test failure in upcoming Julia version 1.5 #62

rfourquet opened this issue Apr 24, 2020 · 1 comment · Fixed by #63

Comments

@rfourquet
Copy link

A PkgEval run for a PR which changes the generated numbers for randn! indicates that the tests of this package might fail in Julia 1.5 (and on Julia current master). Apologies if this is a false positive.
cf. https://github.com/JuliaCI/NanosoldierReports/blob/7de24e455342298cbef56826b5827f0d7640d2c1/pkgeval/by_hash/b89e35c_vs_098ef24/logs/WriteVTK/1.5.0-DEV-71a4a114c2.log
jipolanco added a commit that referenced this issue Apr 24, 2020
@jipolanco
Tests: workaround recent changes to randn!
8438f37 
This should fix #62 (needs to be tested...).
@jipolanco
Copy link
Member

Good to know, thanks!

@jipolanco jipolanco mentioned this issue Apr 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix tests on Julia master JuliaVTK/WriteVTK.jl
2 participants
@jipolanco @rfourquet