Initial work to overhaul debug logging #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 19, 2022
Closed
rikhuijzer
reviewed
May 25, 2022
Co-authored-by: Rik Huijzer <rikhuijzer@pm.me>
Codecov Report
@@ Coverage Diff @@
## master #826 +/- ##
==========================================
+ Coverage 78.37% 80.53% +2.16%
==========================================
Files 37 36 -1
Lines 2705 2646 -59
==========================================
+ Hits 2120 2131 +11
+ Misses 585 515 -70
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marking as draft for now since this depends on work in JuliaLogging/LoggingExtras.jl#64 yet to be merged. See that PR for the discussion around what
@debugv N msgis/does and how it's being used here.