Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return serve task #71

Merged
merged 4 commits into from
Oct 31, 2018
Merged

Conversation

amgad-naiem
Copy link
Contributor

This is to enable fetch(serve(app, port)) for sync run because of new changes in @sync in Julia 0.7 JuliaLang/julia#27164

This is to enable fetch(serve(port))
@codecov-io
Copy link

codecov-io commented Sep 9, 2018

Codecov Report

Merging #71 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #71   +/-   ##
======================================
  Coverage    90.9%   90.9%           
======================================
  Files           6       6           
  Lines          55      55           
======================================
  Hits           50      50           
  Misses          5       5
Impacted Files Coverage Δ
src/server.jl 100% <ø> (ø) ⬆️
src/basics.jl 79.16% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e281cce...3f49e40. Read the comment docs.

@amgad-naiem
Copy link
Contributor Author

Should fix #73 and #44 as well

@MikeInnes
Copy link
Collaborator

👍 Thanks!

@MikeInnes MikeInnes merged commit 849d72c into JuliaWeb:master Oct 31, 2018
@axsk axsk mentioned this pull request Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants