Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The dependency on jquery could be removed in examples/chat-client.html #85

Closed
widged opened this issue Jan 11, 2018 · 4 comments
Closed

Comments

@widged
Copy link
Contributor

widged commented Jan 11, 2018

As I played with the examples, I made changes to the js code in examples/chat-client.html. https://github.com/widged/WebSockets.jl/blob/master/examples/chat-client.html.
Let me know if this is of any interest to you and whether you are ok with es6 or prefer strict es5.

@hustf
Copy link
Collaborator

hustf commented Jan 11, 2018

Pull request welcome!
IE11 people, if this does not work, can use the old versions.
And it is good to get rid of the dependency.

@widged
Copy link
Contributor Author

widged commented Jan 13, 2018

Done. Do not hesitate to let me know if you need more information.

@hustf
Copy link
Collaborator

hustf commented Jan 14, 2018

Before this pull request, Firefox indicated:

Using //@ to indicate sourceMappingURL pragmas is deprecated. Use //# instead
[Learn More]
jquery-1.9.1.min.js:1
Use of getPreventDefault() is deprecated.  Use defaultPrevented instead.
jquery.js:68

@hustf
Copy link
Collaborator

hustf commented Jun 11, 2018

Part of tagged release 0.5.

@hustf hustf closed this as completed Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants