Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing the dependency on jquery. Using es6 #86

Merged
merged 1 commit into from
Jan 20, 2018
Merged

Conversation

widged
Copy link
Contributor

@widged widged commented Jan 13, 2018

Sending a pull request, to follow up on #85

@coveralls
Copy link

coveralls commented Jan 14, 2018

Coverage Status

Coverage remained the same at 87.324% when pulling 3bdc1bd on widged:master into 9570932 on JuliaWeb:master.

@hustf
Copy link
Collaborator

hustf commented Jan 14, 2018

We will drop Julia 0.5 support now, in a separate pr before tagging a new version.
The Julia 0.6 win32 failure is interesting. One of the browsers failed to respond in the same way as before. Will look more closely on the appveyor logs.

@hustf hustf mentioned this pull request Jan 14, 2018
@hustf
Copy link
Collaborator

hustf commented Jan 14, 2018

This removes some deprecation warnings in Firefox. The style is unfamiliar but we need to keep up with the times.

The behaviour in IE 11 is confusing. Could you additionaly push some warning for those with old browsers? Here's one recipe:
https://stackoverflow.com/questions/29046635/javascript-es6-cross-browser-detection

@hustf
Copy link
Collaborator

hustf commented Jan 20, 2018

Tried to rerun appveyor tests a couple of times.
Possible explanation for the failure in appveyor:
Chrome is launced first, firefox second. There's an 8 seconds pause in between, yet Firefox opens the first websocket. Chrome is usually slower than Firefox. Also, chrome is slower because of Julia compile times on the first run. Thus, a chrome and a firefox sockets are assigned the same socket number by the underlying software.
A solution may be to switch the order of testing Chrome and Firefox here. This is of course irrelevant to this PR, but we won't tag a new version before the tests consistently pass.

@hustf hustf closed this Jan 20, 2018
@hustf hustf reopened this Jan 20, 2018
@hustf hustf merged commit c3da21f into JuliaWeb:master Jan 20, 2018
@coveralls
Copy link

coveralls commented Jan 20, 2018

Coverage Status

Coverage remained the same at 87.324% when pulling 3bdc1bd on widged:master into 9570932 on JuliaWeb:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants