feat: Meet api interoperability guidelines #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interoperability guidelines: https://rust-lang.github.io/api-guidelines/interoperability.html Add derives for `Eq`, `Copy`, and `Clone` where possible (but no `Copy` + `Iterator`) Add derives for `Ord` where it does't seem misleading (i.e. no `Ord` on `Point` because it's 2d, but trivial `Ord` on `ConstCap`). Add derives for `Hash`: - for `Point` and `Boundary`, which could hypothetically be used as sensible keys - for the capacity types, which could hypothetically be nested within a sensible key type - not for `QuadTree`, the iterators, or the error
|
@Zoybean thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
interoperability guidelines: https://rust-lang.github.io/api-guidelines/interoperability.html
I've added derives for
Eq,Copy, andClonewhere possible, and forOrdwhere it didn't seem misleading (i.e. noOrdonPointbecause it's 2d, but trivialOrdonConstCap).I added derives for
HashforPointandBoundary, which I thought could hypothetically be used as sensible keys for some structure, and for the capacity types, which could hypothetically be nested within a sensible key, but not e.g.QuadTree, the iterators, or the error.