-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vim Motions #10
Comments
Hello! |
Hi! I was first thinking about vim motions like |
I would love to see this too. I use Vim as my primary editor and vim motions feel so natural to me, so I initially had a hard time playing around with |
Ideally you would navigate with A great start would be something like this: I think |
I am currently working on it in https://github.com/Julien-cpsn/ATAC/tree/10-vim-motions. The implemenation will be simple at first. |
Thats great! I'll happily test that feature and provide feedback. Trying to implement the full range of vim motions in the text area might be way too much (unless theres a library for that or something), since theres a lot of more complex motions that vim users frequently rely on (for examlple |
@mzndr the text area lib that I use has an implementation of it So I'll try to do something like this |
Sounds great! A lot of vim is muscle memory, so its always hard to tell whats missing before you actually use it. But lets be honest, even basic vim motions would be a huge improvement for vim users, and its really great that you're working on it. Love to see it! |
@mzndr @brandon1024 @diego-rapoport @ndtoan96 @greyblake @kayuxx I have been working on the configurable key-bindings and Vim implementation for the last 20 hours (no joke) All the code is here: https://github.com/Julien-cpsn/ATAC/tree/10-vim-motions You can pull it. At first you will see that almost nothing has changed. The Vim shortcuts are almost fully implemented when editing the request body If you struggle finding keys etc, you can press Also, if you have any question, do not hesitate Enjoy! |
@kayuxx is your backspace problem resolved? (when editing the URL) |
Hey @Julien-cpsn!! Still getting used to it, but most of default keybinds were already good like I could think of another good key: I had some difficulties trying to edit the value of params. If you want me to test some other things I'd be very glad to help! |
Thanks for your precious feedback! I did some changes regarding what @ndtoan96 said here https://github.com/Julien-cpsn/ATAC/pull/44/files and my personnal thoughts. Here are the updates:
The x key has been fixed!
Actually, the c key came from
I am begging you to do so 😆 |
This would be a natural UX enhancement as TUI apps (like LazyGit) already have some sort of vim navigations at least. |
Read 3 messages before this one in order to test it out hahah. I wrote down the procedure
Very good! Can I put it in my readme ? |
Of course! 🚀
In this matter, I made the |
@NachoNievaG very great! |
@Julien-cpsn Yeah, it works. I just checked the keybindings and it was mapped to |
@kayuxx is it ready for production you think? Btw you can pull the branch to get some updates |
@Julien-cpsn Yes, I think it's ready to be used. It just has one thing to do. It would be great to implement these Vim keybindings #44. |
Is it planned to have Vim motions in general navigation and editing?
The text was updated successfully, but these errors were encountered: