-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: (draft) import from cURL #49
Conversation
This looks great! I would totally use it. |
@NachoNievaG Yeah i agree, that sounds like a good idea. I have updated the pull request to allow picking where you import the request. 2024-04-26.17-50-00.mp4 |
@jwtly10 @NachoNievaG Hello guys, Thanks for your personnal investment in this project |
Hello @jwtly10, great work here! Concerning the cURL import part, everything seems ok (did not have time to locally test it yet) However², the idea behind this popup is great and I think we should implement it (but not this way). I suggest a simplier thing that will be more practicle for everyone: a CLI argument. (Also, I'd like the user to precise which format he's importing from, so this way will be better) At the end we get something like this: atac import curl my_collection/my_request ./import_tests/example_curl What do you think about it? (also @NachoNievaG) |
@Julien-cpsn I agree completely - reading just from cmdline will be a much leaner implementation too. It was difficult to make any decisions without your feedback so thanks for getting back. I really like the project and I use it daily so I have no problem contributing back where I can 👍🏽 I'll fix the pr over the next day or so. |
I totally understand no worries. I hope you are enjoying the new v0.15.0 features!! Big updates are coming :)
Thanks man, I put my soul into it 😂
I can do it if you like |
Although I agree as well, a few UI/UX enhancements seems fair to be able to handle all CRUD available. # this would go to each existing file to export
atac import curl my_collection ./import_tests/...
# or more bin flag oriented, in which "import_tests" is a dir.
# as -r for being recursive.
# -k --kind or -t --type to define the import kind/type.
atac import -r --kind curl my_collection ./import_tests PS: I refer |
This reverts commit a01c7e2.
@NachoNievaG I think that TUIs are nice, but after thinking about it I do agree in this case its a little bit over kill. While this is not my code base so perhaps my understanding of the best way to implement this was wrong - but my solution felt quite hacky, especially for something that only has a single use case. I do also think command line argument can be extremely useful for scripting too (i dont have this use case but CLA maintains the possibility). @Julien-cpsn I have made the change so I believe this PR is ready for a final review. It doesn't support a recursive flag as @NachoNievaG mentioned but this should be relatively simple to implement if its something you see value in. |
Hello @jwtly10 @NachoNievaG I finalized the PR here #66 (I tried to commit to @jwtly10 's repo, but did not succeed) I also implemented the Here's the video: Enregistrement.2024-05-05.223215.mp4Any feedback? |
(the merge was a fail) |
This is a WIP implementation of importing curl files into ATAC - requested in #48
It should support all browsers Copy > Copy as cURL dev function, and parse Bearer Tokens, headers, and URL params.
There are some points that should be discussed:
There may be some cases I have missed as this is a very draft impl while the above are addressed.
Here is a demo:
2024-04-25.23-12-01.mov
Thanks!