forked from argoproj/argo-cd
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync option #1
Open
JulienFuix
wants to merge
33
commits into
master
Choose a base branch
from
syncOption
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Sync option #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onation (argoproj#14255) * Proposal for decoupling application sync from control plane user using impersonation Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> * Moved the proposal document to the right directory Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> * Update docs/decouple-application-sync-user-using-impersonation Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com> Signed-off-by: Anand Francis Joseph <anandfrancis.joseph@gmail.com> * Update docs/decouple-application-sync-user-using-impersonation Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com> Signed-off-by: Anand Francis Joseph <anandfrancis.joseph@gmail.com> * Update docs/decouple-application-sync-user-using-impersonation Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com> Signed-off-by: Anand Francis Joseph <anandfrancis.joseph@gmail.com> * Modified the proposal to have control in AppProjects alone instead of Application and AppProject Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> * Removed proposal placed in wrong directory and corrected examples Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> * Update docs/proposals/decouple-application-sync-user-using-impersonation Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Anand Francis Joseph <anandfrancis.joseph@gmail.com> * Update docs/proposals/decouple-application-sync-user-using-impersonation Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Anand Francis Joseph <anandfrancis.joseph@gmail.com> * Addressed review comments Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> * Additional corrections Signed-off-by: anandf <anjoseph@redhat.com> * Fixed alternative proposals section to include only AppProject based approach Signed-off-by: anandf <anjoseph@redhat.com> * Added information on impersonation and added related links Signed-off-by: anandf <anjoseph@redhat.com> * Added examples for remote cluster destination with the required RBAC access Signed-off-by: anandf <anjoseph@redhat.com> * Fixed clusterrole and clusterrolebinding creation commands Signed-off-by: anandf <anjoseph@redhat.com> * Addressed review comments from Akram Signed-off-by: anandf <anjoseph@redhat.com> * Corrected RBAC to include serviceaccounts that can be impersonated as swell Signed-off-by: anandf <anjoseph@redhat.com> * Address few more review comments from Ishita, Akram Signed-off-by: anandf <anjoseph@redhat.com> * Fixed a typo and updated the last updated date field Signed-off-by: anandf <anjoseph@redhat.com> * Added information of the sync hook behaviour and also corrected the namespace to match that of destination Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> * Changed proposal to meet the latest api design using destinationServiceAccounts Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> * Fixed proposal document to use destinationServiceAccounts struct Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> * Renamed proposal file to have .md extension Signed-off-by: anandf <anjoseph@redhat.com> * Using glob pattern instead of regex, and corrected the order of precedence when multiple matches are available Signed-off-by: anandf <anjoseph@redhat.com> --------- Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> Signed-off-by: Anand Francis Joseph <anandfrancis.joseph@gmail.com> Signed-off-by: anandf <anjoseph@redhat.com> Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* chore(ci): run ci checks conditionally This should prevent docs changes from having the need to run e2e tests etc, and prevent backend changes from needing to run ui tests, and vice versa. This is similar to previous attempts (see argoproj#16706 and argoproj#13507), with the difference here that we add the if checks on each _step_ rather than each _job_ - the reason being that most of these jobs are required, and if we skip whole jobs any PR which does this will be left hanging indefinitely, so Github forces us to do this on a step level instead. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore(ci): run ci checks conditionally Try conditional jobs, according to https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/troubleshooting-required-status-checks#handling-skipped-but-required-checks Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore(ci): add composite test-e2e action This is a workaround for the e2e tests which do not run yet report `pending` when they are actually skipped. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> --------- Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Co-authored-by: Remington Breeze <remington@breeze.software> Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com>
…14949) * change path to display root Signed-off-by: Eshwar Hebbur Shivakumar <eshwar1011235@gmail.com> * Fix inequality typo Signed-off-by: Eshwar Hebbur Shivakumar <eshwar1011235@gmail.com> * Fix lint issues Signed-off-by: Eshwar Hebbur Shivakumar <eshwar1011235@gmail.com> --------- Signed-off-by: Eshwar Hebbur Shivakumar <eshwar1011235@gmail.com>
Signed-off-by: Adam Huganir <adam@huganir.com>
Signed-off-by: Tal Yitzhak <taly@lightrun.com> Co-authored-by: Tal Yitzhak <taly@lightrun.com> Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com>
The document says I should registed configMap named argocd-notifications-cm but then uses placeholder in examples. Signed-off-by: Petr Studeny <studenyp@gmail.com>
* Update the Okta SSO docs * fill out the OIDC section with step-by-step instructions on using Okta with custom authorization servers * adjust outdated docs about updating the docs Signed-off-by: Jonas Courteau <jonas.courteau@abcellera.com> * Add the Okta version that these docs are written against Signed-off-by: Jonas Courteau <jonas.courteau@abcellera.com> --------- Signed-off-by: Jonas Courteau <jonas.courteau@abcellera.com> Signed-off-by: Dan Garfield <dan@codefresh.io> Co-authored-by: Dan Garfield <dan@codefresh.io>
Which allows you to reuse the same hostname. Co-authored-by: Boris Smidt <boris.smidt@restore.eu> Co-authored-by: pasha-codefresh <pavel@codefresh.io>
Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
argoproj#17111) Bumps library/golang from 1.21.3 to 1.22.0. --- updated-dependencies: - dependency-name: library/golang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…roj#17092) Bumps [yarn](https://github.com/yarnpkg/yarn) from 1.22.10 to 1.22.13. - [Release notes](https://github.com/yarnpkg/yarn/releases) - [Changelog](https://github.com/yarnpkg/yarn/blob/master/CHANGELOG.md) - [Commits](yarnpkg/yarn@1.22.10...v1.22.13) --- updated-dependencies: - dependency-name: yarn dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io>
…er (argoproj#16806) Bumps library/redis from 7.0.11 to 7.2.4. --- updated-dependencies: - dependency-name: library/redis dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io>
…7096) Bumps [yarn](https://github.com/yarnpkg/yarn) from 1.22.10 to 1.22.21. - [Release notes](https://github.com/yarnpkg/yarn/releases) - [Changelog](https://github.com/yarnpkg/yarn/blob/master/CHANGELOG.md) - [Commits](yarnpkg/yarn@1.22.10...v1.22.21) --- updated-dependencies: - dependency-name: yarn dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io>
Bumps library/node from 20.6.1 to 21.6.1. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io>
Signed-off-by: fengshunli <1171313930@qq.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io>
…j#16652 (argoproj#16653) * use repo root, not app path Signed-off-by: Prune <prune@lecentre.net> correct patch Signed-off-by: Prune <prune@lecentre.net> * use Getwd to find the root path for diff commands Signed-off-by: Prune <prune@lecentre.net> * set dot a default for argo app commands Signed-off-by: Prune <prune@lecentre.net> * revert default values Signed-off-by: Prune <prune@lecentre.net> * patch diff in TestNamespacedResourceDiffing Signed-off-by: Prune <prune@lecentre.net> * patching some diff and sync Signed-off-by: Prune <prune@lecentre.net> * patch remaining diff in error Signed-off-by: Prune <prune@lecentre.net> --------- Signed-off-by: Prune <prune@lecentre.net>
The existing backend filters get triggered even on frontend-only or docs-only changes, which should not be the case. The reason for this seems to be the fact that each filter line is ORed rather than ANDed. To remedy this, we put all the filters on the same line. I tried the filter out in a REPL (https://runkit.com/blakepettersson/65c3daba99653f0008c74eda). This is a filter using picomatch (the same library `dorny/paths-filter` uses). Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: asingh51 <ashutosh_singh@intuit.com> Co-authored-by: asingh51 <ashutosh_singh@intuit.com>
…rd (argoproj#17168) * Add support for passing Sentinel username and password Signed-off-by: ShlomiTubul <shlomi.tubul@placer.ai> * fix align with var naming Signed-off-by: ShlomiTubul <shlomi.tubul@placer.ai> * fix align with var naming Signed-off-by: ShlomiTubul <shlomi.tubul@placer.ai> --------- Signed-off-by: ShlomiTubul <shlomi.tubul@placer.ai> Co-authored-by: ShlomiTubul <shlomi.tubul@placer.ai>
…abled (argoproj#17097) * fix: stop initializing deployment informer if dynamic sharding is disabled Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * feat: updated sharding cache getter func Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> --------- Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
Signed-off-by: Jan Schumann <js@schumann-it.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io>
Signed-off-by: David Grizzanti <dgrizzanti@users.noreply.github.com>
* Template.md targetRevision typo fixed Signed-off-by: Ajay Chidambaram <105060495+chidambaram27@users.noreply.github.com> * retrigger checks Signed-off-by: Ajay Chidambaram <105060495+chidambaram27@users.noreply.github.com> * sign off Signed-off-by: chidambaram27 <chidambaramk.27@gmail.com> Signed-off-by: Ajay Chidambaram <105060495+chidambaram27@users.noreply.github.com> * sign off Signed-off-by: Ajay Chidambaram <105060495+chidambaram27@users.noreply.github.com> --------- Signed-off-by: Ajay Chidambaram <105060495+chidambaram27@users.noreply.github.com> Signed-off-by: chidambaram27 <chidambaramk.27@gmail.com>
* helm-repo Signed-off-by: Surajyadav <harrypotter1108@gmail.com> * Update docs/user-guide/helm.md Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com> Signed-off-by: Suraj yadav <harrypotter1108@gmail.com> --------- Signed-off-by: Surajyadav <harrypotter1108@gmail.com> Signed-off-by: Suraj yadav <harrypotter1108@gmail.com> Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com>
…oj#17016) (argoproj#17167) * fix: infer correct shard in statefulset setup Signed-off-by: Lukas Wöhrl <lukas.woehrl@plentymarkets.com> * fix the case if only a single replica Signed-off-by: Lukas Wöhrl <lukas.woehrl@plentymarkets.com> * fix: resolving pointer on shard compare Signed-off-by: Lukas Wöhrl <lukas.woehrl@plentymarkets.com> * fix: add readlock for cluster accessor Signed-off-by: Lukas Wöhrl <lukas.woehrl@plentymarkets.com> * fix: use defer to protect access of 'shard' Signed-off-by: Lukas Wöhrl <lukas.woehrl@plentymarkets.com> * fix: revert locking in getclusteraccessor Signed-off-by: Lukas Wöhrl <lukas.woehrl@plentymarkets.com> * fix: handle nil shard case Signed-off-by: Lukas Wöhrl <lukas.woehrl@plentymarkets.com> * fix: handle any nil shard value as false Signed-off-by: Lukas Wöhrl <lukas.woehrl@plentymarkets.com> * fix: handle nil case and fix another missing pointer dereference Signed-off-by: Lukas Wöhrl <lukas.woehrl@plentymarkets.com> * revert Signed-off-by: Lukas Wöhrl <lukas.woehrl@plentymarkets.com> * fix: added tests and fixed some behaviour bugs Signed-off-by: Lukas Wöhrl <lukas.woehrl@plentymarkets.com> * test: add test to validate that Shard value is not overriden Signed-off-by: Lukas Wöhrl <lukas.woehrl@plentymarkets.com> * fix: added tests and fixe the case when server is changed inside a secret Signed-off-by: Lukas Wöhrl <lukas.woehrl@plentymarkets.com> * tests: add test cases for infering the shard logic Signed-off-by: Lukas Wöhrl <lukas.woehrl@plentymarkets.com> --------- Signed-off-by: Lukas Wöhrl <lukas.woehrl@plentymarkets.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: