use sha1 Compare method (#122)

JunNishimura · Jun 17, 2023 · 557e647 · 557e647
1 parent 08618e8
commit 557e647
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/cmd/commit.go b/cmd/commit.go
@@ -147,7 +147,7 @@ func isIndexDifferentFromTree(index *store.Index, tree *object.Tree) (bool, erro
 		if string(gotEntries[i].Path) != string(index.Entries[i].Path) {
 			return true, nil
 		}
-		if gotEntries[i].Hash.String() != index.Entries[i].Hash.String() {
+		if !gotEntries[i].Hash.Compare(index.Entries[i].Hash) {
 			return true, nil
 		}
 	}

diff --git a/internal/object/tree_test.go b/internal/object/tree_test.go
@@ -77,7 +77,7 @@ func TestNewTree(t *testing.T) {
 			for i := 0; i < len(got.Children); i++ {
 				gotChild := got.Children[i]
 				wantChild := tt.want.Children[i]
-				if gotChild.Hash.String() != wantChild.Hash.String() {
+				if !gotChild.Hash.Compare(wantChild.Hash) {
 					t.Errorf("got = %v, want = %v", gotChild.Hash.String(), wantChild.Hash.String())
 				}
 				if gotChild.Name != wantChild.Name {

diff --git a/internal/store/reflog.go b/internal/store/reflog.go
@@ -70,7 +70,7 @@ func (r *Reflog) load(rootGoitPath string, head *Head, refs *Refs) error {
 			record.hash = hash
 
 			// references
-			if head.Commit.Hash.String() == sp1[1] {
+			if head.Commit.Hash.Compare(hash) {
 				record.isHead = true
 			}
 			branches := refs.getBranchesByHash(hash)

diff --git a/internal/store/refs.go b/internal/store/refs.go
@@ -185,7 +185,7 @@ func (r *Refs) getBranchPos(branchName string) int {
 func (r *Refs) getBranchesByHash(hash sha.SHA1) []*branch {
 	var branches []*branch
 	for _, branch := range r.Heads {
-		if branch.hash.String() == hash.String() {
+		if branch.hash.Compare(hash) {
 			branches = append(branches, branch)
 		}
 	}

diff --git a/internal/store/refs_test.go b/internal/store/refs_test.go
@@ -106,7 +106,7 @@ func TestLoadHash(t *testing.T) {
 			if err := b.loadHash(goitDir); !errors.Is(err, tt.wantErr) {
 				t.Errorf("got = %v, want = %v", err, tt.wantErr)
 			}
-			if b.hash.String() != tt.want.String() {
+			if !b.hash.Compare(tt.want) {
 				t.Errorf("got = %s, want = %s", b.hash, tt.want)
 			}
 		})