Syslog rate limit configuration support #153
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keboliu
reviewed
Oct 13, 2022
keboliu
approved these changes
Oct 21, 2022
Junchao-Mellanox
force-pushed
the
syslog-rate-limit-containercfgd
branch
from
540edbd to
9f8f50b
Compare
|
@Junchao-Mellanox please update your local |
nazariig
suggested changes
Oct 24, 2022
|
re-create one: #155 |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| containercfgd.ContainerConfigDaemon.register_handler('LoadMock', mock_handler_cls) | ||
| daemon = containercfgd.ContainerConfigDaemon() | ||
| daemon.load({}) | ||
| mock_handler_instance.handle_init_data.assert_called_once |
Check notice
Code scanning / CodeQL
Statement has no effect
nazariig
approved these changes
Oct 25, 2022
Junchao-Mellanox
force-pushed
the
syslog-rate-limit-containercfgd
branch
from
c82c00e to
f73e392
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)