-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup #277
Open
aminya
wants to merge
36
commits into
JunoLab:master
Choose a base branch
from
aminya:rollup
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Rollup #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove unused imports
2 tasks
underscore instead of the old plus version
@pfitzseb Could you review this? If you have any questions we can have a skype call. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We made it 😃 Fixes #144
Now it loads 2.6X faster
reduces the ink load time by 110ms + 20ms for julia-client
After Ink rollup and Katex movement
After Ink rollup
without
Katex movementWithout Ink rollup
npm run debug
To achieve I made some changes to the code:
One difference: I used static import in ink.coffee (which bundles everything into one file). If you want I can change this to dynamic import (which makes use of Rollup's code splitting). I did not do this since I was not sure how these variables are used on the julia-client side, and using dynamic import may ruin the performance if these are called right away from the Julia client.
Registering
Similar to JunoLab/atom-indent-detective#23
Commit history is verbose so you can review it easily.
In sync with JunoLab/atom-julia-client#750