Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

guest vs host - profile type and how people are categorized #376

Open
gerbrent opened this issue Sep 2, 2022 · 2 comments · May be fixed by JupiterBroadcasting/show-scraper#34
Open

guest vs host - profile type and how people are categorized #376

gerbrent opened this issue Sep 2, 2022 · 2 comments · May be fixed by JupiterBroadcasting/show-scraper#34
Assignees
@kbondarev @elreydetoda
Labels
bug Something isn't working help wanted Extra attention is needed show-scraper related to the show-scraper

Comments

@gerbrent
Copy link
Collaborator

gerbrent commented Sep 2, 2022 •
edited
Loading

Facts

Take Alex's profile in ./content/people. There he is listed as type: host (in this line)

The Problems

Episode Guest card - links incorrectly

An Episode page with Alex as a Guest - Office Hours 11 - has Alex listed in the "Guest" section, however the URL on his card is to jupiterbroadcasting.com/**hosts**/alex

This link should be to jupiterbroadcasting.com/**guests**/alex

Guests page - no card for Alex

Other People suffer the same:

Brent, for instance. Presumably anyone who is both a host of certain Shows and a guest of others. Potentially also a profile who was a guest of a show at one time, and also at a certain time a host (Brent in LUP, for instance. He's been a guest and a host at different times.

Could potentially be associated with changes in #121 ?

@elreydetoda you might be able to investigate more give you're the author of the above? Though aware it may be unrelated..
@gerbrent gerbrent added bug Something isn't working help wanted Extra attention is needed show-scraper related to the show-scraper labels Sep 2, 2022
@gerbrent
Copy link
Collaborator Author

gerbrent commented Sep 6, 2022 •
edited
Loading

potentially related:

note there exists a /content/hosts and a /content/people directory. Wondering why the mostly-empty /content/hosts exists.....

(should be a separate issue perhaps, if unrelated?)

@elreydetoda elreydetoda mentioned this issue Sep 7, 2022
Closed
@ChanceM
Copy link
Contributor

ChanceM commented Sep 7, 2022

@elreydetoda since this data is populated via the scraper duplication of the data isn't as big of a deal. A small modification to the scraper to produce an additional people file appended with -guest (ie alex-guest.md) will correct this with no other modifications needed here. But from the files in this repo it looks like there have been manual changes. Also the scraper produces additional files not seen in this repo which look to be show specific.

@ChanceM ChanceM linked a pull request Sep 8, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kbondarev kbondarev

@elreydetoda elreydetoda

Labels
bug Something isn't working help wanted Extra attention is needed show-scraper related to the show-scraper
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add check for hosts that are guests ChanceM/show-scraper
4 participants
@gerbrent @kbondarev @elreydetoda @ChanceM