Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for hosts that are guests #34

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ChanceM
Copy link
Collaborator

@ChanceM ChanceM commented Sep 8, 2022

Adds check for guest records that were clobbered by being a host and adds a guest file output.

Fixes JupiterBroadcasting/jupiterbroadcasting.com#376

@gerbrent
Copy link
Contributor

gerbrent commented Sep 8, 2022

@elreydetoda wanna have a look at this one too? Low-ish priority.

@elreydetoda
Copy link
Collaborator

Ya, I can try and take a look at it this weekend.

The scraper is currently a lot more difficult to validate consistency, and I want to make sure I don't break anything with plenty of time to validate changes.

@gerbrent
Copy link
Contributor

gerbrent commented Sep 9, 2022

This is the way.

@gerbrent gerbrent requested a review from elreydetoda September 9, 2022 04:11
@ChanceM
Copy link
Collaborator Author

ChanceM commented Sep 17, 2022

@elreydetoda I noticed there is a bash script in the repo that links all hosts to guests... seems a small assumption, but probably safe. I still think the cascade method might be something to look at since it does look like JB is accepting PRs against the people content for future updates not populated by the scrapper.

It might be a messy rebuild but would set it up for easier updates to both profiles while also being flexible enough to allow changes to just one if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

guest vs host - profile type and how people are categorized
3 participants