Add support for Vault namespaces (used in Vault Enterprise) #39
Conversation
src/vault.py
Outdated
| @@ -198,7 +198,7 @@ def __init__(self, args, envs): | |||
|
|
|||
| # Setup Vault client (hvac) | |||
| try: | |||
| self.client = hvac.Client(url=self.envs.vault_addr, token=os.environ["VAULT_TOKEN"]) | |||
| self.client = hvac.Client(url=self.envs.vault_addr, namespace=os.environ["VAULT_NAMESPACE"], token=os.environ["VAULT_TOKEN"]) | |||
There was a problem hiding this comment.
It appears VAULT_NAMESPACE becomes mandatory when set this way, can it be made optional, and an additional error message added?
|
Hello, It appears this fails if VAULT_NAMESPACE is not provided, can this be made optional? Some additional tests around vault namespaces would be needed as well. |
Hi @Just-Insane, thanks for the feedback. I have fixed the issue where VAULT_NAMESPACE was required and have added some scripts to allow running tests locally without setting up a vault beforehand. Let me know what you think. When it comes to additional tests I am not sure how to best test this as this is an enterprise feature. Any hints? Cheers, |
|
I'm also not sure how to test the Vault namespace feature, as I don't have an enterprise license. It looks like this is all part of |
Make some slight adjustments to the built-in help related to #39
Add support for Vault namespaces (used in Vault Enterprise)
Description
This PR adds support Vault Enterprise namespaces. In accordance with
vault-clithe Vault Namespace can be configured using the environment variableVAULT_NAMESPACE.Also refer to: https://www.vaultproject.io/docs/commands#vault_namespace
Fixes #38
Type of change
Please delete options that are not relevant.
Checklist:
Mentions:
@Just-Insane