remove alert on overview map to filter portfolio #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #13500: remove filter alert on overview map. |
kiwansim
added a commit
that referenced
this pull request
Apr 5, 2024
* Initial login flow and components to connect to authentication server * Add logout route and token management functions to AuthClient * Add registration component and endpoints * Add /authenticate endpoint for registering then automatically logging in a user * Use email in username field everywhere * Remove register-only (no auth) route * Add route for updating user email, clean up register code * Add endpoint for refreshing a token * Small refactor for AuthClient functions * Clean up auth provider server routes, unify shared code * Save user email in browser memory * Update .env.sample with auth client variables * Format AuthClient * Temporary login UI for demo * Pull authentication base URL from environment variables * Clean up login components, add check for if account already exists * Store auth_token in secure HttpOnly cookie * Check if access_token cookie is present on initial page load * Return appropriate HTTP error when unauthenticated, delete cookie on logout * Remove client-side Javascript access to token entirely * Add default value for AUTH_BASE_URL * Move auth server URL to environment * Add deploy preview to allowed origins * Ensure single trailing slash in client-side URL construction * path.join instead of manually concatenating server paths * Fix type error * Small refactor to add automatic refresh token flow to auth request * Remove unused refresh route * Small cleanup of user routes * Update user existence check route * Temporary logging for debugging deployed server * Clean up error messaging * Enable get request for authentication check * Add password reset routes * Add overview page login component, intial styles, linting * Porting design system CSS changes from portfolio filters PR * Clean up AuthClient and email signup component formatting * Additional CSS, small style cleanup for Login inputs * Add frontend email verification route and view * Add logged in state, feedback for email verification * Add frontend building subscription routes and hook up to component * Fetch list of user subscribed buildings so that we can display the correct CTA * Only pass along necessary headers * Clean up user state, read in top level app component * Clean up login user state * Use React context instead of state machine global state * Add account navigation if user is signed in * Return error if access_token not present * Convert Login to functional component, clean up sign out flow * Add subscription to user context * Base account settings page, route, update email field * Add unsubscribe route and link in overview page * Display subscriptions and unsubscribe on account settings page * Add interactive password requirement UI * Check user email verification status, display appropriate message * CSS pass for overview page email alert components (login, password, subscribe, unsubscribe) * Initial styling pass for account settings page * Send building street address when subscribing, process subscription object * Display full street address in account settings * Generalize user setting fields, add password input * Add backend route for changing password, connect to setting component * Null checks for subscriptions array * Preserve url query parameter when redirecting to locale * Add forgot password frontend pages and components * Initial CSS pass for forgot password, reset password, email verify pages * Add site origin to reset password and subscribe requests * Ability to resend password reset and verification emails * Unsubscribe page for managing email alerts from unauthenticated (email) view * Add standalone login page and nav bar link * Change lingui component * Restore API base URL port * Update strings * Remove unused user existence check * Update refresh token route to handle null access token * Unify authentication route code for extracting access and refresh tokens * Clean up line spacing, linting * Automatically subscribe a user to the building after they sign in via 'Get Updates' * Separate login and registration routes, update UI flow (#742) * Change hover state shadow to #d4d5d0 * Update password requirement styling colors and icons * Change password field label depending on login/sign-up state * Update strings * Clean up Typescript for password/login * Add link to search from Account Settings when no subscriptions are present * Update title of account settings if no subscriptions present * Pipe error messages through authutil * Verify Email landing, confirmation, and error pages (#785) * sc-12394: add dynamic countdown for redirect * prettier * whitelist demosite * run black * whitelist regex all deploy previews * whitelist regex all deploy previews * ugh cors * add all cors lol * revert cors_origin_whitelist sites, original demosite gives 401 for auth_check * re-add #785 demosite link after setting REACT-APP-API-BASEURL for branch * swap delaySeconds variable for const * pre-verification screen shows only if user object in context is valid * remove UserContext references, manually async fetch user * console.log * assert user object required * handle bad requests with info from json body, clean up verify email page * handle async state update after successful verification * sc-12766 handle authcheck object properly, clearing and updating * sc-12808 identify auth required routes to trigger redirect on logout * prettier * User object not clearing on logout, Redirects from restricted pages (#795) * sc-12766 handle authcheck object properly, clearing and updating * sc-12808 identify auth required routes to trigger redirect on logout * prettier * call auth server api to check if email has acct * sc-12776 login vs register screens toggle depending on existing account check * run black and lingui extract * Validate email address for routing log in / register flow (#803) * sc-12766 handle authcheck object properly, clearing and updating * sc-12808 identify auth required routes to trigger redirect on logout * prettier * call auth server api to check if email has acct * sc-12776 login vs register screens toggle depending on existing account check * run black and lingui extract * react context not updating when clicking log out on building page * login edge cases, password regex fix, styling for alerts and errors * run prettier and black * eslint useless escape regex moved to top of file * add preview site to whitelist * handle submit debugging * Revert "handle submit debugging" This reverts commit 1188537. * refactor login error logic * refactor again * sc-13022 stricter regex for client side email validation * sc-13035 forgot password screen UI parity * sc-13035 most of the UI parity issues found from VQA * global button style update * UI parity for building page email alert container - add new pill, info secure, etc * sc-13023 add redirect after successful password reset * sc-13124 add standalone email verification success page * modify email rule to include + symbol * add the lines accidentally removed during merge conflicts with master * replace modal close button from plaintext to CloseButton import * update modal style, add CTA modal for email verification * ui parity for login on buildings page and prettier * comment out unused vars * add preview site to cors * formatting * add another preview site to cors origin * remove numbered deploy preview links, add regex * add wow demo site to cors allowed origins * remove "share" from nav (#851) Remove the "share" button from WOW nav header. * remove alert on overview map to filter portfolio (#844) When we launched portfolio filters we added an alert on overview map that prompts users to check out the portfolio tab to filter down the properties. We are now seeing extremely low rates of clicks on this alert, so are going to remove it along with the launch of email alerts. * remove new pill on portfolio tab (#845) Remove the temporary "new" pill on portfolio tab from launch of filters * show modal & prevent subscription above 15 bldg limit (#842) Prevent users from signing up for more than 15 buildings, and show modal explaining this when they click "get updates" and direct users to edit their list of building in account settings and also link to typeform survey where they can request access to more buildings. * Base font size change (#853) change base font size from 10px to 16px, move spectre.scss into wow src & remove from dependencies, find/replace all rem units with calculation to reflect the new base size. * remove legacy/new banner (#850) Remove the legacy/new version banner from the top of wow. * Multi-step log in/sign up modal, with user type (#849) - adds ability for account sign up to happen all within a modal from the building page - adds a required step for account sign up, asking user type (multiple-choice or write in) - adds verify email/ re-send email step to the end of log in/sign up flow - refactors email input into separate component (like PasswordInput * Add validation/error handling to account settings update credentials (#854) This PR adds input validation and error handling to the forms for updating user email and password on the account settings page to ensure the new email is valid and not already in use, and that the new password satisfies rules. It swaps in the new <EmailInput>, and adapts the existing validation/error handling logic from ` to show input- and page-level alerts. It prevents the default form reload and controls the toggling of edit mode after successful submission. Also adds an option to show an input-level error for password when rules aren't shown. Also fixes some spacing/styles that might have gotten messed up with the modal login changes. Also adds an input-level error state for password when the rule validation messages aren't shown (eg. for empty input when logging in). There is now a "callout" box under email when not editing if you haven't verified your email. And when you successfully change your email we mark it un-verified and send a verify email on the server side (JustFixNYC/auth-provider#17) and then the callout appears. * change privacy info modal to new-tab links (#859) Remove the info icon opening modal and instead just use links to privacy and terms of use page (opening in new tab) And only show this when registering new account, not when logging in. * lingui (#860) just running yarn lingui extract - we'd been delaying on PRs, but want to make sure they are done now so we don't get the {variable} showing up on pages during QA testing * update unsubscribe page for unsubscribe-all via email (#858) We'll have two links in our emails - Unsubscribe All and Manage Subscriptions Both will go to WOW /unsubscribe page with a param u=<token> and the "all" version will also have all=true. If the token and all=true are present, it should automatically call AuthClient.emailUnsubscribeAll(token) and show a success messaging confirming you've unsubscribed from all building updates. If the token is present but not all, it should do what its' already doing: automatically fetch user subscriptions via AuthClient.emailUserSubscriptions(token) and display them all with remove buttons to call AuthClient.emailUnsubscribeBuilding(token). And there will also be a button at the top to 'Unsubscribe From All'. If there are no subscriptions but not because you had the all=true option, have message saying no subscriptions. In either situation where there are no subscriptions, prompt user to subscribe to buildings or delete their account (same as on account settings page). When you first land on the page it shows the standard Loading... placeholder until it can either fetch subscriptions or complete the unsubscribe. Edge case: What if you land on this page without the token param? Maybe redirect to login, as we do for all other pages like this when you aren't logged in. We'll wait to deal with that all at once in [sc-13754] In a separate PR we'll add a button for the login-auth version "unsubscribe from all" to the Account Settings page. [sc-13811] Accompanying changes to auth endpoints: JustFixNYC/auth-provider#16 * Remove onsite landing page for email verification (#855) * remove landing page for verify email button * switch verify_email from authenticated request to a non authenticated post * update dead links to agency websites on timeline (#831) The DOB and HPD links in indicator descriptions for the timeline are dead. DOB permits one was just moved, the others were changed a bit more, but there is now one that covers hpd complaints and violations/inspection info, so using that for both. * Use new combined hpd complaints and problems table (#832) HPD has created a new dataset on open data that combines the previously separate complaints and problems files. This is essentially just the same data joined on complaint id, like we were doing ourselves. * add new compliant types for translation (#834) when switching over to the new combined HPD complaints and problems data (#832) there were a few new complaint types, so this PR adds them on to the list we have for translations * New Crowdin updates (#835) * Feature: Rent Stabilized Units Indicator (#838) * Add url params for timeline indicators (#830) * add indicator param to timeline route, and update history shallow on selection * fix optional route definition * replace url rather than adding to history * swap summary for timeline in route tests * fix links to timeline, reorg helper funs * reset url to default indicator if param is invalid or missing * remove console.log --------- Co-authored-by: kiwan <kiwan.sim@gmail.com> * Add Rent Stabilized Units indicator to Timeline (#837) * change rent stab latest year to 2022 * add 2022 as rsunitslatestyear, update yml dependenc, add csv for tests * update nycdb src branc * add nycdb test data for rentstab and hpd_complaints * add rentstab indicator to timeline * update MonthlyTimelineData type to match SQL * remove stacked bar denoting market rate units, add horizontal line for latest total unit count * add link to THE CITY's map visualization * run prettier * fussing around with viz UI * change minor variable to trigger deploy * yaxis max handled in switch statement * run lingui extract --------- Co-authored-by: Maxwell Austensen <m.austensen@gmail.com> --------- Co-authored-by: Maxwell Austensen <maxwell@justfix.org> Co-authored-by: Maxwell Austensen <m.austensen@gmail.com> * New translations messages.po (Spanish) (#839) * Update indicators timeline start years & select components (#841) * Add url params for timeline indicators (#830) * add indicator param to timeline route, and update history shallow on selection * fix optional route definition * replace url rather than adding to history * swap summary for timeline in route tests * fix links to timeline, reorg helper funs * reset url to default indicator if param is invalid or missing * remove console.log --------- Co-authored-by: kiwan <kiwan.sim@gmail.com> * Add Rent Stabilized Units indicator to Timeline (#837) * change rent stab latest year to 2022 * add 2022 as rsunitslatestyear, update yml dependenc, add csv for tests * update nycdb src branc * add nycdb test data for rentstab and hpd_complaints * add rentstab indicator to timeline * update MonthlyTimelineData type to match SQL * remove stacked bar denoting market rate units, add horizontal line for latest total unit count * add link to THE CITY's map visualization * run prettier * fussing around with viz UI * change minor variable to trigger deploy * yaxis max handled in switch statement * run lingui extract --------- Co-authored-by: Maxwell Austensen <m.austensen@gmail.com> * replace Dropdown with Select react component, refactor timespan and indicator selectors * apply JF style to react select * prettier * update startYear for different indicators * run prettier * lingui * remove commented out code --------- Co-authored-by: Maxwell Austensen <maxwell@justfix.org> Co-authored-by: Maxwell Austensen <m.austensen@gmail.com> * New Crowdin updates (#840) * New translations messages.po (Spanish) * New translations messages.po (Spanish) * New translations messages.po (Spanish) --------- Co-authored-by: kiwansim <emily.kiwan.sim@gmail.com> * Add API endpoint for email alerts data (#827) This PR adds new API endpoint(s) to get the data we need to generate custom wow email alerts. These will be used exclusively by our server that generates and sends the emails. * add tests and error validation for alert endpoints (#846) Follow up to adding new endpoints for email alert data (#827). Adds tests for all new endpoints, bumps nycdb version & test data for oca_metadata update, adds conditional validation for params on more flexible indicator endpoints. * feature: autofocus the address search field (#863) auto-focus the address input on page load * Add react-error-overlay@6.0.9 (#856) fix to error that was breaking hot reload when developing requiring hard reload on changes * update hpd complaints table for alerts api (#864) Update the HPD Complaints table we're using in the email alerts data api. Now using the new combined complaints and problems, and so we'll be counting problems (though still calling them complaints. This matches what we do on WOW already, how they are displayed on HPD Online, and DAP Portal. * limit subscriptions to 15 (not 16) (#866) Limit users to 15 subscriptions (fix typo from #842 that was allowing 16) * Email verification landing page states, expiration, resend email without auth (#867) * refactor verifyEmailPage, get expired case to work again * add endpoint for email verification with user token * remove commented out code * Update client/src/containers/VerifyEmailPage.tsx Co-authored-by: Maxwell Austensen <maxwell@justfix.org> --------- Co-authored-by: Maxwell Austensen <maxwell@justfix.org> * wip * more reset flow changes * Revert "more reset flow changes" This reverts commit fac68c8. * Revert "wip" This reverts commit 7c0a5b4. * Button integration [sc-13707] (#857) * Add component library * Replace portfolio links and signup button * gitignore yalc files * Add react-error-overlay@6.0.9 * Engagement panel: - JustFix link - Social share buttons * AdressToolbar - New Search link - Data Export button * Summary Page - Data Request button * Not Registered Page - Search button * NYCHA - Useful Links - JustFix link - Search link * Portfolio Table - Next and Previous buttons * Portfolio page - Apply buttons on filter dropdowns * Remove unused icon and make justfix link on homepage external * Formatting * Upgrade component-library version * SocialShare FB button Twitter button Email button * Only keep font family * format * Upgrade component library version * Warn aabout social shares opening new windows: * Wrap 'Opens in a new window' in translation function * Use text variant for portfolio table pagination buttons * Make apply buttons smaller and left align links and h6s on homepage * format * Update useful links to use our new styles * Use new Link component for Take Action and View Data buttons on Overview tab. Also move JFCLLinkInternal to it's own component. * Update Download button * - Change share text - Remove icon from www.justfix.org link - Add icon to data request link - Make entire ACRIS text a link - Center portfolio links on homepage - Wrap engagment items at a wider width * In EngagementPanel, when narrow put signup button below email input and add padding * clear alert and input-errors on toggle login/signup (#865) When manually toggling between Log in and Sign up flows we clear all the page-level alerts and input-level errors. While I was at it I also added autofocus to the email input box on the Nav login/signup page. * add reset password landing pages, validate new password inputs (#868) This PR changes the forgot/reset password flows, and goes along with changes to the auth backend in JustFixNYC/auth-provider#31 * Login mirror bug (#870) On the building page, while the login/register modal is open on the page the login was being mirrored. This PR removes that by using a placeholder for on-page while the modal is open. This placeholder mimics what is there when you first land on the page (the email input). In the input box it persists whatever was in there when the modal opened, so that it doesn't update if you were to change the email in the modal. When you close the modal it swaps the placeholder for the real so the email will reset to whatever it is in state. * Content updates (#869) Various content changes, updating from the main content spreadsheet * refactor unsubscribe page (#872) Refactor the unsubscribe/manage subscriptions page that you land on via email links. * add component library buttons, fix verified condition on building page (#873) I was starting to implement the component-library buttons, then Leslie flagged that the condition was wrong on the building pages. When you're not verified you should always see the prompt to verify and not allow users to subscribe until they are. previously it was allowing them to subscribe then the prompt to verify would show up after. So this fixes that plus a few button swaps that will get continued in another PR. * make all emails lowercase before calling api (#874) * Use component library buttons in email alerts (#875) This PR swaps in component-library buttons for all the email alerts work, and creates <SendNewLink> that toggles between a "send new link" button -> "✔️ link sent" confirmation. There are also some changes to the reset password and verify pages for expired links for consistency and to update for content doc. * don't clear errors on login/signup toggle, only hide them (#876) When toggling between login/signup we had issue of errors persisting, then in #865 we cleared them on toggle. But this created a new bug that allowed you to create an account with a password not meeting rules if you first toggled between login/signup. Now we just turn off the showing of errors on toggle, but don't clear the errors themselves so submit is still prevented. * component-library to v32.2 for alert style fixes (#880) There were some issues with alert styles getting out of scope - fixed in JustFixNYC/component-library#23 * custom "other" user type not required (#877) For user type we were previously requiring a custom input when "other" was selected, this PR removes that requirement so you can check "other" and leave the input blank and it saves the type as "OTHER". This also fixes an issue that would have had the spanish translation of user types saved on the DB, now they are always uppercase english labels for presets or the user text. * Layout change and other style updates (#878) * layout change, refactoring reused card styles, other tweaks to card components with layout change mock * use props for <TimelineLink > * address pr comments, fix sc-14192 * linter --------- Co-authored-by: Maxwell Austensen <m.austensen@gmail.com> * More component library button updates (#879) Was a bit too hasty in merging in #875 , so this fixes a couple things that either broke or were left out, plus some changes we decided on after. fix some naming consistency for isEmailResent that I accidentally left out change "signup" toggle back to old style text button change user setting edit button to be component library text button fix typo in cancel button type, "button" not "submit" change the unsubscribe-all on unsubscribe page to secondary variant * fix input error spacing, add util classes (#881) This PR adds margin and padding utility classes for design-system spacing increments that we create for org site. (later this should probably move to component library) Spectre had some of these too, so I commented those out (until we can finally move away from all spectre stuff) and updated any references to them to use our new ones instead. Then I used the new spacing classes to fix the input error spacing for email/password/user-type. And finally I moved the "forgot password?" link from the password component to login to match the updated placement in figma. * fix forgot password link type styles on login (#883) Small fix to the type styles for the forgot password link on login. (missed this initially in #881) * fix alignment issues (#882) * sc-14206 align address tool bar buttons * sc-13965 sc-14211 send new link font and alignment * sc-14220 left align get repairs link * remove unnecessary styling * add focus state outline for all text inputs (#884) Adds a focus state for all text inputs, matching design system (temporary until component library is ready) * update component-library for tertiary button and link icon updates (#885) Update to component-library v0.33.0 for tertiary button styles and link icons styles. * add jfcl-locale-link, link focus, pw toggle focus (#886) update link focus states everywhere to match component library standard (blue outline) remove spectre link focus styles, make old .button.is-text focus style same as link until we can transition these to component library option add focus state to password visibility toggle [sc-14200] add a <JFCLLocleLink> to simplify usage [sc-14267] remove a copy/paste typo that added a ga tag to forgot password This also fixes the focus stats for privacy/terms links on sign up [sc-13896] * use 16px in text inputs to prevent zooming on mobile safari (#887) On mobile safari it was zooming in on text inputs when focused. This is because the font size was < 16px, so this bumps them all up to 16px (until we can swap with component library). Testing on the preview link it does not zoom now! * update HPD Online link for bbl search results, useful links and alerts api (#889) When the new HPD Online first launched it wouldn't allow you to link to search results based on BBL like the old version. This is important because since WOW uses BBLs for our pages, HPD uses their own "HPD building ID" and a single BBL can have multiple buildings. When there is only one building we can know that and link directly to the page, but when there are multiple we need to link to these bbl search results and the user can select the building they are interested in. Now that HPD allows these links, we update our own "useful links" section. Also in this PR I add this link (single building or search results) as an optional "indicator" on the email alerts endpoint so that we can include those in the building update emails just like useful links. The corresponding PR that makes use of the new api changes: JustFixNYC/auth-provider#34 * Content updates for login flow (#888) This makes updates to content for login/signup flow for more consistency with header/sub-header text. Also remove an old step for "verify reminder" that wasn't being used. Also cuts a line about sending error report from verify page. [sc-14236] Also centers the resend verify email within the sign up modal [sc-14270] I also clean up the login styles - nothing other than the following was added, everything else just rearranged to make it a little more clear. * Nav bar updates (#890) * sc-14206 align address tool bar buttons * sc-13965 sc-14211 send new link font and alignment * sc-14220 left align get repairs link * remove unnecessary styling * [sc-14207] [sc-14051] update nav bar to reflect more current design system mocks, fix wrapping nav bar buttons, hand icon on hover * demosite tag alignment in mobile * add verify step to nav signup flow, same as in modal (#891) Previous the signup flow from Nav would end after user type selection and redirect users to the account settings page. This was confusing during initial user testing since it never said anything about email verification until later it was show on building pages, also there is no need to do anything on account settings after sign up. This PR removes that redirect and shows the same "verify email" prompt as we show at the end of the on-page/in-modal sign up flow. So the final step looks like this. * update content changes for user type options (#892) content update for user type options * Standalone page (#893) This adds a standardized "standalone" page design for login/signup, forgot-password, reset-password, verify email (plus a modified version for unsubscribe/manage subscriptions). [sc-14218] This new page also gets a new minimal footer. [sc-13964] Mobile styles are also fixed for all these pages with the new layout. [sc-14066] All automatic/countdown redirects are removed from login/signup via nav, reset-password and verify. [sc-14144] The login flow from nav now has an extra final step. If not verified you get the same prompt to do so as at the end of sign up, and it sends a new email. And if you are already verified then you get a a new "success" step with a link to the homepage. Focus now automatically shifts to the password input after submitting email in the login/signup flows. [sc-14271] Also, I realized there was a bad copy/paste error on the reset-password page - it was sending a verify email instead of a reset one! So I fixed that and also realized there was a problem with the request because cookies weren't getting sent and those are needed for accessing session on the auth server. I also changed the JF logo svg (also used in nav) to a component so that we can make use of the "currentColor" to style with css instead of adding a second black version. * [sc-13983] remove flickering between add building / success state (#894) * Account settings and manage subscriptions page styles (#895) * fix broken pw reset request with token * add standalone page, start transitioning over * add login success step, mobile standalone styles, footer * fix footer alignment, and page scrolling on mobile * fix desktop styles, add link to JF logo * remove unused prop for redirects * greyed out site for modal color darkened, manage subscriptions page style update * other account settings style updates * remove unused import * Update client/src/styles/AccountSettingsPage.scss Co-authored-by: Maxwell Austensen <maxwell@justfix.org> * Update client/src/styles/AccountSettingsPage.scss Co-authored-by: Maxwell Austensen <maxwell@justfix.org> * Update client/src/styles/UserSetting.scss Co-authored-by: Maxwell Austensen <maxwell@justfix.org> * Update client/src/styles/AccountSettingsPage.scss Co-authored-by: Maxwell Austensen <maxwell@justfix.org> --------- Co-authored-by: Maxwell Austensen <m.austensen@gmail.com> Co-authored-by: Maxwell Austensen <maxwell@justfix.org> * lingui extract (#896) * fix missing plural in lingui (#897) There's some weird issue with lingui (the very old version we're on) where the lingui extract doesn't work on if it's imported before Trans (lingui/js-lingui#372) * remove unused import --------- Co-authored-by: Shannon Kao <shannon@justfix.nyc> Co-authored-by: shakao <34112083+shakao@users.noreply.github.com> Co-authored-by: Maxwell Austensen <m.austensen@gmail.com> Co-authored-by: Maxwell Austensen <maxwell@justfix.org> Co-authored-by: JustFix <110484547+JustFix-org@users.noreply.github.com> Co-authored-by: Kevin Finn <superkevin@gmail.com> Co-authored-by: Steve Giordano <steve1nyc@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we launched portfolio filters we added an alert on overview map that prompts users to check out the portfolio tab to filter down the properties. We are now seeing extremely low rates of clicks on this alert, so are going to remove it along with the launch of email alerts.
[sc-13500]