Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[regression]Closed issue #46 seems to have come back... #53

Closed
Vangelis66 opened this issue Mar 7, 2022 · 2 comments
Closed

[regression]Closed issue #46 seems to have come back... #53

Vangelis66 opened this issue Mar 7, 2022 · 2 comments
Labels
bug Something isn't working fixed

Comments

@Vangelis66
Copy link

Browser: Latest (UXP-based) Serpent 52.9.0 (2022-02-25) (32-bit)
Browser profile: Fresh/clean one (with default settings), only this extension installed
Extension version: Latest release, i.e. v1.12.15

p1

STR

  1. Load in a tab, e.g. 8446565 (#48)
  2. Click the Load diff area; diff will display correctly 👍 .
  3. Now normally reload that same tab; depending on the time of day (i.e. completely random 😸 ), you'll either get a misplaced and disabled Load diff button like below:

p2

or a correctly aligned Load diff button, but disabled nonetheless 😠 :

p3

Since we know that the code that addressed #46 is already inside v1.12.15, and with me not being a coder in the slightest, I'd hazard a guess that some type of race-condition is taking place that prevents that code from actually functioning... Perhaps it has to be the last to run (or is every polyfill inside the extension injected asynchronously?) ?

As already noted in #46, CTRL+F5 will, again, restore things...

PS: The SeaHOH fork is also plagued by the same issue currently (at least for me, that is...).

SeaHOH added a commit to SeaHOH/github-wc-polyfill that referenced this issue Mar 7, 2022
@SeaHOH SeaHOH added the bug Something isn't working label Mar 7, 2022
@SeaHOH
Copy link
Collaborator

SeaHOH commented Mar 7, 2022

This will be fixed in next release.

@Vangelis66
Copy link
Author

I tried latest beta, 1.2.16b1, and in non-exhaustive testing it appears to address very well this regression 👍 ; congrats and thanks a bunch 🥇 !

SeaHOH added a commit that referenced this issue Mar 9, 2022
@SeaHOH SeaHOH added the fixed label Mar 9, 2022
@SeaHOH SeaHOH closed this as completed Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed
Projects
None yet
Development

No branches or pull requests

2 participants