Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test for the presence of window.fetch #90

Merged
merged 1 commit into from
Apr 26, 2019
Merged

fix: test for the presence of window.fetch #90

merged 1 commit into from
Apr 26, 2019

Conversation

wilhuff
Copy link
Contributor

@wilhuff wilhuff commented Apr 26, 2019

This makes gaxios compatible with tests running with jsdom which defines
window.

Fixes #87 and firebase/firebase-admin-node#512.

@ghost
Copy link

ghost commented Apr 26, 2019

There were the following issues with this Pull Request

  • Commit: fafb54a
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@ghost
Copy link

ghost commented Apr 26, 2019

There were the following issues with this Pull Request

  • Commit: 758cfbe
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

This makes gaxios compatible with tests running with jsdom which defines
`window`.
@JustinBeckwith JustinBeckwith changed the title Actually test for the presence of window.fetch. fix: test for the presence of window.fetch Apr 26, 2019
@JustinBeckwith JustinBeckwith merged commit d3036fe into googleapis:master Apr 26, 2019
@JustinBeckwith
Copy link
Contributor

🎉 This PR is included in version 2.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jrschumacher
Copy link

@JustinBeckwith could we get this for the v1.x branch? #122

googleapis/google-auth-library-nodejs@v3.1.2 branch requires 1.8.x

googleapis/google-auth-library-nodejs@v4 uses gaxios@v2 but has a defect googleapis/google-auth-library-nodejs#711

@JustinBeckwith
Copy link
Contributor

Greetings! I haven't had time to dig into googleapis/google-auth-library-nodejs#711 yet, but I would be really surprised if this was introduced due to any changes in gaxios. The proxy handling code in here has pretty much been the same from the start. Are you experiencing otherwise?

@jrschumacher
Copy link

@JustinBeckwith I'm sorry this was an amateur mistake. I had typed the URL as http not https. I'm not sure why I'm getting a socket hang up though.

@chimirala
Copy link

Hi Team,

I am trying to connect BigQuery from Node locally but receiving ENETUNREACH error. Not sure what would be error.

error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gaxios fails with jest
4 participants