-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build!: drop support for node 16 #575
Conversation
bbc865d
to
13de96f
Compare
if (flags.urlRewriteSearch && flags.urlRewriteReplace) { | ||
options.urlRewriteExpressions = [ | ||
{ | ||
pattern: new RegExp(flags.urlRewriteSearch), |
Check failure
Code scanning / CodeQL
Regular expression injection High
command-line argument
res.end(JSON.stringify(err)); | ||
function return404(response: http.ServerResponse, error: Error) { | ||
response.writeHead(404); | ||
response.end(JSON.stringify(error)); |
Check warning
Code scanning / CodeQL
Exception text reinterpreted as HTML Medium
Exception text
response.statusCode = 301; | ||
response.setHeader('Content-Type', 'text/html; charset=UTF-8'); | ||
response.setHeader('Content-Length', Buffer.byteLength(doc)); | ||
response.setHeader('Location', request.url + '/'); |
Check warning
Code scanning / CodeQL
Server-side URL redirect Medium
user-provided value
res.end(JSON.stringify(err)); | ||
function return404(response: http.ServerResponse, error: Error) { | ||
response.writeHead(404); | ||
response.end(JSON.stringify(error)); |
Check warning
Code scanning / CodeQL
Information exposure through a stack trace Medium
stack trace information
This information exposed to the user depends on
stack trace information
This information exposed to the user depends on
stack trace information
🎉 This PR is included in version 6.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
BREAKING CHANGE: This module now requires node.js 18 and up. It includes a variety of related changes:
It's entirely possible this change didn't break anything for most users, but it's also possible it did.