connect leaks Coroutine on subsequent reconnects (Android)

[twyatt]

Characteristic changes are forwarded from the Callback to the Observers via launchIn(scope) but the Coroutine is never cancelled.

kable/core/src/androidMain/kotlin/Peripheral.kt

Lines 175 to 178 in d9ff2ce

	connection
	.characteristicChanges
	.onEach(observers.characteristicChanges::emit)
	.launchIn(scope, start = UNDISPATCHED)

[twyatt]

I may have misunderstood or overlooked that upstream the Channel is closed, and thus: this launched Coroutine should terminate when the upstream Channel closes (which is triggered via a disconnect event in the Android Callback).

tl;dr this may not be a bug (it might not leak) at all.

[twyatt]

Confirmed that this is not a bug. In #193, the completion of the flow identified in this issue is relied on for observation handling. Testing of SNAPSHOTs produced from #193 confirmed that (as identified in #139 (comment)), the flow is terminated upon disconnected signal in Android's BluetoothGattCallback.