-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support constructing Peripheral
s using builder lambda
#108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 38fed09.
twyatt
requested review from
a team,
QuantumRand,
cedrickcooke and
davidtaylor-juul
June 8, 2021 05:43
davidtaylor-juul
approved these changes
Jun 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 very nice
sdonn3
approved these changes
Jun 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it
QuantumRand
approved these changes
Jun 8, 2021
- `ReplaceWith` was not working, so dropped - Fixed deprecated functions overlapping with builder function signature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage details can be found in the README Peripherals section.
Worth mentioning (with more detail beyond the
README
) is theonServicesDiscovered
option (in the builder lambda):It allows for actions to be performed "after service discovery".
Without this feature, performing an action upon connection required wrapping Kable's
Peripheral
so that operations could be performed after theconnect
(additionally, ensuring those operations were idempotent and thread-safe was difficult and error prone).Kable already incorporates the necessary locks/safe-guards so this makes it possible for consumers to leverage that functionality.
The
DiscoveredServicesPeripheral
was created to provide a reduced functionalityPeripheral
which is available in theonServiceDiscovered
lambda. It excludes the abilityconnect
ordisconnect
, whereasconnect
from the lambda would create a deadlock. So, this limited functionalityPeripheral
prevents a footgun situation.