Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix write "without response" support #312

Merged
merged 3 commits into from
Apr 13, 2022
Merged

Fix write "without response" support #312

merged 3 commits into from
Apr 13, 2022

Conversation

twyatt
Copy link
Member

@twyatt twyatt commented Apr 10, 2022

Closes #157

@twyatt twyatt added the apple label Apr 10, 2022
@twyatt twyatt mentioned this pull request Apr 10, 2022
Closed
@twyatt twyatt requested review from a team, cedrickcooke and davertay-j and removed request for a team April 10, 2022 06:20
@twyatt twyatt force-pushed the twyatt/write-without-response branch 2 times, most recently from 713673f to 8ae50e0 Compare April 10, 2022 06:31
@twyatt twyatt force-pushed the twyatt/write-without-response branch from 8ae50e0 to 97205ad Compare April 10, 2022 06:52
@twyatt twyatt changed the title Add support for writing without response on Apple Fix write "without response" support Apr 10, 2022
@twyatt twyatt marked this pull request as ready for review April 10, 2022 23:15
@twyatt twyatt requested a review from Phoenix7351 as a code owner April 10, 2022 23:15
@twyatt twyatt added this to the 0.16.1 milestone Apr 10, 2022
@twyatt twyatt requested a review from a team April 11, 2022 19:20
@twyatt twyatt enabled auto-merge (squash) April 13, 2022 02:21
@twyatt twyatt disabled auto-merge April 13, 2022 02:22
@twyatt twyatt enabled auto-merge (squash) April 13, 2022 02:22
@twyatt twyatt merged commit 90c45b1 into main Apr 13, 2022
@twyatt twyatt deleted the twyatt/write-without-response branch April 13, 2022 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davertay-j davertay-j davertay-j approved these changes

@cedrickcooke cedrickcooke cedrickcooke approved these changes

@sdonn3 sdonn3 sdonn3 approved these changes

@Phoenix7351 Phoenix7351 Awaiting requested review from Phoenix7351

Assignees
No one assigned
Labels
apple
Projects
None yet
Milestone
0.16.1
Development

Successfully merging this pull request may close these issues.

write suspends indefinitely on subsequent calls when WithoutResponse is used
4 participants
@twyatt @sdonn3 @cedrickcooke @davertay-j