Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify/optimize characteristic and descriptor lookups #56

Merged
merged 6 commits into from
Jan 15, 2021
Merged

Simplify/optimize characteristic and descriptor lookups #56

merged 6 commits into from
Jan 15, 2021

Conversation

twyatt
Copy link
Member

@twyatt twyatt commented Jan 12, 2021 •
edited
Loading

When a service, characteristic or descriptor cannot be found, NoSuchElementException is now thrown with a message stating the UUID that could not be found.

On Apple platform, services are now cached on service discovery (which matches behavior of the other platform targets).

Closes #14
Closes #38

@twyatt
Simplify/optimize characteristic and descriptor lookups
cde26cc 
When a service, characteristic or descriptor cannot be found,
`IOException` is now thrown with a `message` stating the UUID that could
not be found.

On Apple platform, services are now cached on service discovery (which
matches behavior of the other platform targets).

Closes #14
Closes #38
@twyatt twyatt marked this pull request as ready for review January 12, 2021 08:05
@twyatt twyatt requested review from a team, sdonn3 and cedrickcooke January 12, 2021 08:05
davidtaylor-juul
davidtaylor-juul approved these changes Jan 12, 2021
View reviewed changes
core/src/androidMain/kotlin/PlatformService.kt Outdated Show resolved Hide resolved
core/src/jsMain/kotlin/Peripheral.kt Show resolved Hide resolved
core/src/jsMain/kotlin/PlatformService.kt Outdated Show resolved Hide resolved
core/src/macosX64Main/kotlin/PlatformService.kt Outdated Show resolved Hide resolved
cedrickcooke
cedrickcooke approved these changes Jan 12, 2021
View reviewed changes
core/src/commonMain/kotlin/Descriptor.kt Outdated Show resolved Hide resolved
core/src/commonMain/kotlin/Service.kt Outdated Show resolved Hide resolved
core/src/commonMain/kotlin/Characteristic.kt Outdated Show resolved Hide resolved
Phoenix7351
Phoenix7351 approved these changes Jan 14, 2021
View reviewed changes
Copy link
Contributor

@Phoenix7351 Phoenix7351 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@twyatt

This comment has been minimized.

Sign in to view
@twyatt twyatt merged commit 34e34c5 into main Jan 15, 2021
@twyatt twyatt deleted the twyatt/lookup branch January 15, 2021 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtaylor-juul davidtaylor-juul davidtaylor-juul approved these changes

@cedrickcooke cedrickcooke cedrickcooke approved these changes

@Phoenix7351 Phoenix7351 Phoenix7351 approved these changes

@sdonn3 sdonn3 Awaiting requested review from sdonn3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@twyatt @Phoenix7351 @cedrickcooke @davidtaylor-juul