Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Options builder #722

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Add Options builder #722

merged 2 commits into from
Jul 29, 2024

Conversation

twyatt
Copy link
Member

@twyatt twyatt commented Jul 26, 2024

Brings JavaScript-side API (of specifying filters) in line with the other platforms (see #695) by providing an Options builder that contains a filters { } bulder.

Closes #723

@twyatt twyatt added javascript major Changes that should bump the MAJOR version number labels Jul 26, 2024
@twyatt twyatt force-pushed the twyatt/js-options-builder branch from 1d6eb0c to ab9cc81 Compare July 26, 2024 03:04
@twyatt twyatt linked an issue Jul 26, 2024 that may be closed by this pull request
@twyatt twyatt added this to the 0.34.0 milestone Jul 26, 2024
@twyatt twyatt marked this pull request as ready for review July 26, 2024 03:20
@twyatt twyatt requested a review from a team as a code owner July 26, 2024 03:20
@twyatt twyatt force-pushed the twyatt/js-options-builder branch from ab9cc81 to 60d0c13 Compare July 26, 2024 08:41
Copy link
Contributor

@davidtaylor-juul davidtaylor-juul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@twyatt twyatt enabled auto-merge (squash) July 29, 2024 17:41
@twyatt twyatt merged commit c6d400d into main Jul 29, 2024
2 checks passed
@twyatt twyatt deleted the twyatt/js-options-builder branch July 29, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript major Changes that should bump the MAJOR version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide Options DSL
3 participants