Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update runTest signature to match runBlocking #18

Merged
merged 1 commit into from
Nov 4, 2020
Merged

Conversation

twyatt
Copy link
Member

@twyatt twyatt commented Nov 2, 2020

No description provided.

@twyatt twyatt added this to the 2.1.0 milestone Nov 2, 2020
@codecov
Copy link

codecov bot commented Nov 2, 2020

Codecov Report

Merging #18 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main      #18   +/-   ##
=========================================
  Coverage     71.42%   71.42%           
  Complexity       17       17           
=========================================
  Files             2        2           
  Lines            28       28           
  Branches          4        4           
=========================================
  Hits             20       20           
  Misses            8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00d23e6...df4f749. Read the comment docs.

@twyatt twyatt marked this pull request as ready for review November 2, 2020 19:41
@twyatt twyatt requested review from a team, sdonn3 and cedrickcooke November 2, 2020 19:41
Copy link
Contributor

@cedrickcooke cedrickcooke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Secret bonus of runTest -- if your last call in @Test fun foo() = runBlocking { /* here */ } returns a non-Unit value, the test will fail. Because runTest guarantees a Unit return, we don't have to worry about that.

@twyatt twyatt merged commit f0955aa into main Nov 4, 2020
@twyatt twyatt deleted the twyatt/runTest branch November 4, 2020 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants