Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module for functional manipulation #21

Merged
merged 4 commits into from
Nov 25, 2020

Conversation

cedrickcooke
Copy link
Contributor

@cedrickcooke cedrickcooke commented Nov 24, 2020

Screen Shot 2020-11-24 at 1 19 01 PM

@cedrickcooke cedrickcooke requested review from twyatt, a team and sdonn3 November 24, 2020 21:10
@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #21 (cf21169) into main (0753a91) will increase coverage by 18.31%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##               main      #21       +/-   ##
=============================================
+ Coverage     71.42%   89.74%   +18.31%     
  Complexity       17       17               
=============================================
  Files             2        9        +7     
  Lines            28       78       +50     
  Branches          4        6        +2     
=============================================
+ Hits             20       70       +50     
  Misses            8        8               
Impacted Files Coverage Δ Complexity Δ
functional/src/commonMain/kotlin/Compose.kt 100.00% <100.00%> (ø) 0.00 <0.00> (?)
functional/src/commonMain/kotlin/Curry.kt 100.00% <100.00%> (ø) 0.00 <0.00> (?)
functional/src/commonMain/kotlin/Memoize.kt 100.00% <100.00%> (ø) 0.00 <0.00> (?)
functional/src/commonMain/kotlin/PartialApply.kt 100.00% <100.00%> (ø) 0.00 <0.00> (?)
functional/src/commonMain/kotlin/Repeat.kt 100.00% <100.00%> (ø) 0.00 <0.00> (?)
functional/src/commonMain/kotlin/Reverse.kt 100.00% <100.00%> (ø) 0.00 <0.00> (?)
functional/src/commonMain/kotlin/Rotate.kt 100.00% <100.00%> (ø) 0.00 <0.00> (?)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0753a91...cf21169. Read the comment docs.

Copy link
Member

@twyatt twyatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome set of tools with unit tests, AMAZING!
Curious where the need for these arose for you?

README.md Show resolved Hide resolved
functional/README.md Outdated Show resolved Hide resolved
functional/build.gradle.kts Outdated Show resolved Hide resolved
functional/api/functional.api Show resolved Hide resolved
@cedrickcooke
Copy link
Contributor Author

Awesome set of tools with unit tests, AMAZING!

Thank you 😄

Curious where the need for these arose for you?

Honestly, nothing immediate. I've wanted some of these in the past and didn't have them, though. Next time, I will.

Copy link
Member

@twyatt twyatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a fixes line to codecov.yml so that codecov picks up this increased coverage. 😉

functional/src/commonMain/kotlin/Repeat.kt Outdated Show resolved Hide resolved
@twyatt twyatt added this to the 2.2.0 milestone Nov 24, 2020
@cedrickcooke cedrickcooke merged commit 8e77f2a into main Nov 25, 2020
@cedrickcooke cedrickcooke deleted the cedrickc/add-functional-module branch November 25, 2020 20:05
@twyatt
Copy link
Member

twyatt commented Nov 25, 2020

@cedrickcooke let me know when you want a release cut.
(We'll just keep adding features to 2.2.0 milestone until a release is needed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants